Change in coreboot[master]: acpi: Bump FADT Minor Version to 3

List overview All Threads
Download

newer

older

Change in coreboot[master]: acpi:...

Change in coreboot[master]: src:...

HAOUAS Elyes (Code Review)

10 Jun 2020 10 Jun '20

5:33 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42250 )

Change subject: acpi: Bump FADT Minor Version to 3 ......................................................................

acpi: Bump FADT Minor Version to 3

Change-Id: I3c7803bcab3a4054280e352fd154cc28bf62f723 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/acpi/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/42250/1

diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index a4ea24b..15794f1 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1239,7 +1239,7 @@ memcpy(header->asl_compiler_id, ASLC, 4); header->asl_compiler_revision = asl_revision;

- fadt->FADT_MinorVersion = 0; + fadt->FADT_MinorVersion = 3;

fadt->firmware_ctrl = (unsigned long) facs; fadt->x_firmware_ctl_l = (unsigned long)facs;

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

HAOUAS Elyes (Code Review)

18 Jun 18 Jun

9:51 a.m.

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42250 )

Change subject: acpi: Bump FADT Minor Version to 3 ......................................................................

Abandoned

Merge Conflict

HAOUAS Elyes (Code Review)

23 Jun 23 Jun

9:41 a.m.

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/42250 )

Change subject: acpi: Bump FADT Minor Version to 3 ......................................................................

Restored

HAOUAS Elyes (Code Review)

9:41 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42250

to look at the new patch set (#2).

Change subject: acpi: Bump FADT Minor Version to 3 ......................................................................

acpi: Bump FADT Minor Version to 3

Change-Id: I3c7803bcab3a4054280e352fd154cc28bf62f723 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/acpi/acpi.c M src/soc/amd/picasso/acpi.c M src/soc/amd/stoneyridge/acpi.c M src/southbridge/amd/agesa/hudson/fadt.c M src/southbridge/amd/cimx/sb800/fadt.c M src/southbridge/amd/pi/hudson/fadt.c 6 files changed, 1 insertion(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/42250/2

Paul Menzel (Code Review)

25 Jun 25 Jun

10:01 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42250 )

Change subject: acpi: Bump FADT Minor Version to 3 ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42250/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42250/2//COMMIT_MSG@8 PS2, Line 8: What is the current default? Please add a reference for the description of the changes between the current minor version and 3.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c7803bcab3a4054280e352fd154cc28bf62f723 Gerrit-Change-Number: 42250 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 25 Jun 2020 08:01:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

8:57 p.m.

Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42250

to look at the new patch set (#3).

Change subject: acpi: Bump FADT Minor Version to 3 ......................................................................

acpi: Bump FADT Minor Version to 3

Regarding ACPI specification 6.3, page #133 current minor version FADT table is 3.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/42250/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/42250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c7803bcab3a4054280e352fd154cc28bf62f723 Gerrit-Change-Number: 42250 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

8:58 p.m.

Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42250

to look at the new patch set (#4).

Change subject: acpi: Bump FADT Minor Version to 3 ......................................................................

acpi: Bump FADT Minor Version to 3

Regarding ACPI specification 6.3, page #133 current FADT table minor version is 3.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/42250/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/42250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c7803bcab3a4054280e352fd154cc28bf62f723 Gerrit-Change-Number: 42250 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Rudolph (Code Review)

26 Jun 26 Jun

7:27 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42250 )

Change subject: acpi: Bump FADT Minor Version to 3 ......................................................................

Patch Set 4:

The last bump of FADT triggered additional checks in windows 10. This commit needs on tests on real hardware to see if it still boots.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c7803bcab3a4054280e352fd154cc28bf62f723 Gerrit-Change-Number: 42250 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 26 Jun 2020 05:27:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:52 p.m.

Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42250

to look at the new patch set (#5).

Change subject: acpi: Bump FADT Minor Version to 3 ......................................................................

acpi: Bump FADT Minor Version to 3

Regarding ACPI specification 6.3, page #133 current FADT table minor version is 3.

Change-Id: I3c7803bcab3a4054280e352fd154cc28bf62f723 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/acpi/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/42250/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/42250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c7803bcab3a4054280e352fd154cc28bf62f723 Gerrit-Change-Number: 42250 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

12 Aug 12 Aug

12:44 a.m.

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42250 )

Change subject: acpi: Bump FADT Minor Version to 3 ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/42250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c7803bcab3a4054280e352fd154cc28bf62f723 Gerrit-Change-Number: 42250 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1367

days inactive

1429

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

HAOUAS Elyes (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)