Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Derek Huang, Brandon Breitenstein, Curtis Chen.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57138 )
Change subject: src/ec/google/chromeec: Add and modify APIs for USB-C DP ALT mode
......................................................................
Patch Set 5: Code-Review+1
(3 comments)
Patchset:
PS5:
The overall is LGTM. Tim/Furquan, do you have any comment for this patch?
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/57138/comment/58a9fc07_242dd6a0
PS5, Line 29: uint16_t svid, int port
maybe can swap port and svid to align with the other api. ie:
(int port, uint16_t svid)
https://review.coreboot.org/c/coreboot/+/57138/comment/bb908c7e_d0b538d1
PS5, Line 39: long timeout, int port
Maybe can swap the port and timeout, ie:
(int port, long timeout)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57138
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id11510c1ff58579ae2cddfe5a4d69646fd84f5c3
Gerrit-Change-Number: 57138
Gerrit-PatchSet: 5
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Sep 2021 15:19:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment