Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Derek Huang, Brandon Breitenstein, Curtis Chen.

Patch set 5:Code-Review +1

View Change

3 comments:

• Patchset:

  • Patch Set #5:

    The overall is LGTM. Tim/Furquan, do you have any comment for this patch?

• File src/ec/google/chromeec/ec.h:

  • Patch Set #5, Line 29: uint16_t svid, int port

    maybe can swap port and svid to align with the other api. ie:
    (int port, uint16_t svid)

  • Patch Set #5, Line 39: long timeout, int port

    Maybe can swap the port and timeout, ie:

    (int port, long timeout)

To view, visit change 57138. To unsubscribe, or for help writing mail filters, visit settings.