Change in coreboot[master]: include/rules.h: Allow .data section on non-XIP stages

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48157 )

Change subject: include/rules.h: Allow .data section on non-XIP stages
......................................................................

include/rules.h: Allow .data section on non-XIP stages

This allows platform that don't run stage XIP to have a .data section.

Change-Id: I40a651398dff374bf6ba75471b07662de96fb434
Signed-off-by: Arthur Heymans 
---
M src/include/rules.h
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/48157/1

diff --git a/src/include/rules.h b/src/include/rules.h
index f503914..a7fc77f 100644
--- a/src/include/rules.h
+++ b/src/include/rules.h
@@ -265,7 +265,7 @@
 #define ENV_STAGE_XIP			(ENV_CACHE_AS_RAM && \
    				 !((ENV_ROMSTAGE || ENV_SEPARATE_VERSTAGE) && CONFIG(NO_XIP_EARLY_STAGES)))
 /* No .data sections with execute-in-place from ROM.  */
-#define ENV_STAGE_HAS_DATA_SECTION	!ENV_CACHE_AS_RAM
+#define ENV_STAGE_HAS_DATA_SECTION	!ENV_STAGE_XIP
 #else
 /* Both .data and .bss, sometimes SRAM not DRAM. */
 #define ENV_STAGE_HAS_DATA_SECTION	1

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48157 )

Change subject: include/rules.h: Allow .data section on non-XIP stages
......................................................................

Patch Set 1: Code-Review+2

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48157 )

Change subject: include/rules.h: Allow .data section on non-XIP stages
......................................................................

Patch Set 2: Verified+1

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48157 )

Change subject: include/rules.h: Allow .data section on non-XIP stages
......................................................................

Patch Set 2: Code-Review-2

(1 comment)

Patchset:

PS2: 
On the S3 resume patch for AMD the .data would need to be restored from a backup.

[S] Change in coreboot[master]: include/rules.h: Allow .data section on non-XIP stages

[Arthur Heymans (Code Review)]

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48157 )

Change subject: include/rules.h: Allow .data section on non-XIP stages
......................................................................

Abandoned