Change in coreboot[master]: include/rules.h: Allow .data section on non-XIP stages

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48157 )


Change subject: include/rules.h: Allow .data section on non-XIP stages
......................................................................

include/rules.h: Allow .data section on non-XIP stages

This allows platform that don't run stage XIP to have a .data section.

Change-Id: I40a651398dff374bf6ba75471b07662de96fb434
Signed-off-by: Arthur Heymans <[e-mail]>
---
M src/include/rules.h
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/48157/1

diff --git a/src/include/rules.h b/src/include/rules.h
index f503914..a7fc77f 100644
--- a/src/include/rules.h
+++ b/src/include/rules.h
@@ -265,7 +265,7 @@
 #define ENV_STAGE_XIP			(ENV_CACHE_AS_RAM && \
 					 !((ENV_ROMSTAGE || ENV_SEPARATE_VERSTAGE) && CONFIG(NO_XIP_EARLY_STAGES)))
 /* No .data sections with execute-in-place from ROM.  */
-#define ENV_STAGE_HAS_DATA_SECTION	!ENV_CACHE_AS_RAM
+#define ENV_STAGE_HAS_DATA_SECTION	!ENV_STAGE_XIP
 #else
 /* Both .data and .bss, sometimes SRAM not DRAM. */
 #define ENV_STAGE_HAS_DATA_SECTION	1

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/48157
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40a651398dff374bf6ba75471b07662de96fb434
Gerrit-Change-Number: 48157
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-MessageType: newchange

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48157 )

Change subject: include/rules.h: Allow .data section on non-XIP stages
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/48157
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40a651398dff374bf6ba75471b07662de96fb434
Gerrit-Change-Number: 48157
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Marshall Dawson <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Mon, 30 Nov 2020 19:23:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48157 )

Change subject: include/rules.h: Allow .data section on non-XIP stages
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/48157
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40a651398dff374bf6ba75471b07662de96fb434
Gerrit-Change-Number: 48157
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Marshall Dawson <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Fri, 08 Apr 2022 12:26:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48157 )

Change subject: include/rules.h: Allow .data section on non-XIP stages
......................................................................


Patch Set 2: Code-Review-2

(1 comment)

Patchset:

PS2: 
On the S3 resume patch for AMD the .data would need to be restored from a backup.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/48157
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40a651398dff374bf6ba75471b07662de96fb434
Gerrit-Change-Number: 48157
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Marshall Dawson <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Fri, 08 Apr 2022 14:50:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in coreboot[master]: include/rules.h: Allow .data section on non-XIP stages

[Arthur Heymans (Code Review)]

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48157 )

Change subject: include/rules.h: Allow .data section on non-XIP stages
......................................................................


Abandoned
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/48157
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40a651398dff374bf6ba75471b07662de96fb434
Gerrit-Change-Number: 48157
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Marshall Dawson <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: abandon