Change in coreboot[master]: drivers/usb: Add chip driver for external USB hub - coreboot-gerrit

4 May 2022


      Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Jon Murphy, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63968 )
Change subject: drivers/usb: Add chip driver for external USB hub
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/usb/ext_hub/Kconfig:
https://review.coreboot.org/c/coreboot/+/63968/comment/af261524_669e334e 
PS3, Line 1: EXTERNAL
Should we remove the EXTERNAL? The help text says `soldered down`, so it's kind of confusing since it's internal to the device.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11d7ccc42d3dce8e136eb771f120825980e5c027
Gerrit-Change-Number: 63968
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Wed, 04 May 2022 22:46:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment