Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Jon Murphy, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63968 )
Change subject: drivers/usb: Add chip driver for external USB hub ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63968/comment/c376d3a0_1112edf6 PS3, Line 9: ACPI nit: too long
File src/drivers/usb/ext_hub/acpi.c:
https://review.coreboot.org/c/coreboot/+/63968/comment/45410b76_5cdbaf92 PS3, Line 44: if (parent->path.type == DEVICE_PATH_USB && parent->path.usb.port_type == 2) : format = "HS%02d"; : else if (parent->path.type == DEVICE_PATH_USB && parent->path.usb.port_type == 3) : format = "SS%02d"; : else : return; Can you reuse usb_ext_hub_acpi_name?
File src/drivers/usb/ext_hub/chip.h:
https://review.coreboot.org/c/coreboot/+/63968/comment/16cbb7c8_7d523b1e PS3, Line 6: drivers_usb_ext_hub_config Should we support support acpi_upc_type?
https://review.coreboot.org/c/coreboot/+/63968/comment/e8afc2ef_092d3b10 PS3, Line 9: port_count Can you add a comment stating this is both super speed and high speed ports?
-
Raul Rangel (Code Review)