David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25431 )
Change subject: soc/intel/denverton_ns: Enable Fast Strings
......................................................................
Patch Set 8:
(1 comment)
Patch Set 7:
(1 comment)
I agree
https://review.coreboot.org/#/c/25431/7/src/soc/intel/denverton_ns/include/s...
File src/soc/intel/denverton_ns/include/soc/msr.h:
https://review.coreboot.org/#/c/25431/7/src/soc/intel/denverton_ns/include/s...
PS7, Line 95: #define FAST_STRINGS_ENABLE_BIT (1 << 0)
: #define SPEED_STEP_ENABLE_BIT (1 << 16)
Can we move this to include/cpu/x86/msr. […]
I think that's a good idea
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25431
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cee3c40299abf14a24128b1ac14f1823f87a0e1
Gerrit-Change-Number: 25431
Gerrit-PatchSet: 8
Gerrit-Owner: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shine Liu
shine.liu@intel.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Fri, 01 Feb 2019 10:16:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment