Change in ...coreboot[master]: sdm845: Add USB support on cheza platform
Chandana Kishori Chiluveru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25213 ) Change subject: sdm845: Add USB support on cheza platform ...................................................................... Patch Set 65: (2 comments) https://review.coreboot.org/#/c/25213/64/src/soc/qualcomm/sdm845/usb.c File src/soc/qualcomm/sdm845/usb.c: https://review.coreboot.org/#/c/25213/64/src/soc/qualcomm/sdm845/usb.c@585 PS64, Line 585: int serdes_tbl_num;
Hmmm... okay, crap, I didn't see all those other differences. […] sounds good, I will separate out the usb_dwc3_cfg data for usb ports.
I will push the changes in next patch https://review.coreboot.org/#/c/25213/64/src/soc/qualcomm/sdm845/usb.c@824 PS64, Line 824: USB3_PCS_PHYSTATUS));
Okay, thanks, just wanted to double-check. […] we already shared the HPG documents to google. I will check more info from shon on this and update you over partner account
-- To view, visit https://review.coreboot.org/c/coreboot/+/25213 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I475a7757239acb8ef22a4d61afd59b304a7f0acc Gerrit-Change-Number: 25213 Gerrit-PatchSet: 65 Gerrit-Owner: T.Michael Turney <tturne@codeaurora.org> Gerrit-Reviewer: Ciluveru chandana kishori <cchiluve@codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: T.Michael Turney <tturne@codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: mturney mturney <mturney@codeaurora.org> Gerrit-CC: Chandana Kishori Chiluveru <cchiluve@qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Fri, 01 Feb 2019 08:59:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner@chromium.org> Comment-In-Reply-To: Chandana Kishori Chiluveru <cchiluve@qualcomm.corp-partner.google.com> Gerrit-MessageType: comment
participants (1)
-
Chandana Kishori Chiluveru (Code Review)