Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32139
Change subject: siemens/mc_apl5: Remove reduced clock rate for I2C0 ......................................................................
siemens/mc_apl5: Remove reduced clock rate for I2C0
There is no device on I2C0 which requires a lower clock rate.
Change-Id: Iaf01be5ea4839c54eb2f0ba95bca272970c24bdb Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com --- M src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb 1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/32139/1
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb index 989ab45..15be7ff 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb @@ -49,18 +49,6 @@ # Enable Vtd feature register "enable_vtd" = "1"
- # Intel Common SoC Config - #+-------------------+---------------------------+ - #| Field | Value | - #+-------------------+---------------------------+ - #| I2C0 | Proximity Sensor | - #+-------------------+---------------------------+ - register "common_soc_config" = "{ - .i2c[0] = { - .speed = I2C_SPEED_STANDARD - }, - }" - device domain 0 on device pci 00.0 on end # - Host Bridge device pci 00.1 off end # - DPTF
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32139 )
Change subject: siemens/mc_apl5: Remove reduced clock rate for I2C0 ......................................................................
Patch Set 1: Code-Review+1
Uwe Poeche has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32139 )
Change subject: siemens/mc_apl5: Remove reduced clock rate for I2C0 ......................................................................
Patch Set 1: Code-Review+1
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32139 )
Change subject: siemens/mc_apl5: Remove reduced clock rate for I2C0 ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32139 )
Change subject: siemens/mc_apl5: Remove reduced clock rate for I2C0 ......................................................................
siemens/mc_apl5: Remove reduced clock rate for I2C0
There is no device on I2C0 which requires a lower clock rate.
Change-Id: Iaf01be5ea4839c54eb2f0ba95bca272970c24bdb Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32139 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Uwe Poeche uwe.poeche@siemens.com Reviewed-by: Werner Zeh werner.zeh@siemens.com --- M src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb 1 file changed, 0 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Werner Zeh: Looks good to me, approved Uwe Poeche: Looks good to me, but someone else must approve
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb index 989ab45..15be7ff 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/devicetree.cb @@ -49,18 +49,6 @@ # Enable Vtd feature register "enable_vtd" = "1"
- # Intel Common SoC Config - #+-------------------+---------------------------+ - #| Field | Value | - #+-------------------+---------------------------+ - #| I2C0 | Proximity Sensor | - #+-------------------+---------------------------+ - register "common_soc_config" = "{ - .i2c[0] = { - .speed = I2C_SPEED_STANDARD - }, - }" - device domain 0 on device pci 00.0 on end # - Host Bridge device pci 00.1 off end # - DPTF
-
Mario Scheithauer (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Uwe Poeche (Code Review)
-
Werner Zeh (Code Review)