Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46231 )
Change subject: soc/intel/xeon_sp: Enable SMI handler
......................................................................
Patch Set 26:
Patch Set 24:
Patch Set 24:
(1 comment)
Does the TCO, gnvs, and smbsus changes belong in this patch? Maybe explain in the commit message if they do.
soc/intel/common has some dependencies which is what I suspect drove those changes. IDK if there is even TCO on these? GNVS is fully broken on this platform, but needs separate fixing (or actual implementing). No idea about smbus.
I have some local improvements I want to push soon, like less skx/cpx boilerplate + proper IED handling. So maybe hold off on merging for a day or two?
TCO is not used, but the common block code assumes the support is there. Hence, I had to put in the ifdef's. Regarding, smbus.h, it's required by common block SMM code also.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46231
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabee5c72f0245ab988d477ac8df3d8d655a2a506
Gerrit-Change-Number: 46231
Gerrit-PatchSet: 26
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Eugene Myers
cedarhouse1@comcast.net
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Nov 2020 05:29:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment