Patch Set 24:

Patch Set 24:

(1 comment)

Does the TCO, gnvs, and smbsus changes belong in this patch? Maybe explain in the commit message if they do.

soc/intel/common has some dependencies which is what I suspect drove those changes. IDK if there is even TCO on these? GNVS is fully broken on this platform, but needs separate fixing (or actual implementing). No idea about smbus.

I have some local improvements I want to push soon, like less skx/cpx boilerplate + proper IED handling. So maybe hold off on merging for a day or two?

TCO is not used, but the common block code assumes the support is there. Hence, I had to put in the ifdef's. Regarding, smbus.h, it's required by common block SMM code also.

View Change

To view, visit change 46231. To unsubscribe, or for help writing mail filters, visit settings.