Attention is currently required from: Sean Rhodes, Tarun Tuli, Subrata Banik, Dinesh Gehlot, Paul Menzel, Sridhar Siricilla.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74435 )
Change subject: soc/intel/common: Fix long delay when ME is disabled
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/74435/comment/905ebfa1_f2181d4f
PS2, Line 281: (CONFIG(SOC_INTEL_CSE_LITE_SKU) && vboot_recovery_mode_enabled())
This might break the logic for Chrome OS. […]
Alternatively, have one if-block for each ORed value, e.g.:
```
/* CSE Lite case */
if ((CONFIG(SOC_INTEL_CSE_LITE_SKU) && vboot_recovery_mode_enabled()) &&
cse_is_hfs1_com_soft_temp_disable()) {
printk(BIOS_INFO, "HECI: coreboot in recovery mode; found CSE Lite in expected "
"SOFT TEMP DISABLE state, skipping EOP\n");
return false;
}
/* Other case */
if (cse_is_hfs1_com_soft_temp_disable()) {
printk(BIOS_INFO, "HECI: coreboot in recovery mode; found CSE in expected "
"SOFT TEMP DISABLE state, skipping EOP\n");
return false;
}
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74435
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I182f30d4fbf43955747c6a7a0b284a43f9c5e4ef
Gerrit-Change-Number: 74435
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dinesh Gehlot
digehlot@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 10 May 2023 19:30:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment