Attention is currently required from: Sean Rhodes, Tarun Tuli, Subrata Banik, Dinesh Gehlot, Paul Menzel, Sridhar Siricilla.

View Change

1 comment:

• File src/soc/intel/common/block/cse/cse_eop.c:

  • Patch Set #2, Line 281: (CONFIG(SOC_INTEL_CSE_LITE_SKU) && vboot_recovery_mode_enabled())

    This might break the logic for Chrome OS. […]

    Alternatively, have one if-block for each ORed value, e.g.:

    ```
    	/* CSE Lite case */
    	if ((CONFIG(SOC_INTEL_CSE_LITE_SKU) && vboot_recovery_mode_enabled()) &&
    		cse_is_hfs1_com_soft_temp_disable()) {
    		printk(BIOS_INFO, "HECI: coreboot in recovery mode; found CSE Lite in expected "
    		       "SOFT TEMP DISABLE state, skipping EOP\n");
    		return false;
    	}

    	/* Other case */
    	if (cse_is_hfs1_com_soft_temp_disable()) {
    		printk(BIOS_INFO, "HECI: coreboot in recovery mode; found CSE in expected "
    		       "SOFT TEMP DISABLE state, skipping EOP\n");
    		return false;
    	}
    ```

To view, visit change 74435. To unsubscribe, or for help writing mail filters, visit settings.