Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44018 )
Change subject: Doc/mb/facebook/monolith: Remove plural *s* ......................................................................
Doc/mb/facebook/monolith: Remove plural *s*
Change-Id: I2d14902f9d975e89cd2842f4c12eab8ca4018fbf --- M Documentation/mainboard/facebook/monolith.md 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/44018/1
diff --git a/Documentation/mainboard/facebook/monolith.md b/Documentation/mainboard/facebook/monolith.md index cdd3208..6e30496 100644 --- a/Documentation/mainboard/facebook/monolith.md +++ b/Documentation/mainboard/facebook/monolith.md @@ -2,7 +2,7 @@
This page describes how to run coreboot on the Facebook Monolith.
-Please note: the coreboot implementation for this boards is in its +Please note: the coreboot implementation for this board is in its Beta state and isn't fully tested yet.
## Required blobs
Paul Menzel has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/44018 )
Change subject: Doc/mb/facebook/monolith: Remove plural *s* ......................................................................
Doc/mb/facebook/monolith: Remove plural *s*
Change-Id: I2d14902f9d975e89cd2842f4c12eab8ca4018fbf --- M Documentation/mainboard/facebook/monolith.md 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/44018/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44018 )
Change subject: Doc/mb/facebook/monolith: Remove plural *s* ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44018/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44018/2//COMMIT_MSG@7 PS2, Line 7: Remove plural *s* I'd mention somewhere that this is to correct a grammatical error
https://review.coreboot.org/c/coreboot/+/44018/2//COMMIT_MSG@8 PS2, Line 8: Jenkins wants you to sign off 😊
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44018
to look at the new patch set (#3).
Change subject: Doc/mb/facebook/monolith: Correct grammatic by removing plural *s* ......................................................................
Doc/mb/facebook/monolith: Correct grammatic by removing plural *s*
Change-Id: I2d14902f9d975e89cd2842f4c12eab8ca4018fbf Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M Documentation/mainboard/facebook/monolith.md 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/44018/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44018 )
Change subject: Doc/mb/facebook/monolith: Correct grammatic by removing plural *s* ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44018/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44018/3//COMMIT_MSG@7 PS3, Line 7: grammatic grammar
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44018 )
Change subject: Doc/mb/facebook/monolith: Correct grammatic by removing plural *s* ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44018/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44018/2//COMMIT_MSG@7 PS2, Line 7: Remove plural *s*
I'd mention somewhere that this is to correct a grammatical error
Done
https://review.coreboot.org/c/coreboot/+/44018/2//COMMIT_MSG@8 PS2, Line 8:
Jenkins wants you to sign off 😊
Done
Patrick Georgi has uploaded a new patch set (#4) to the change originally created by Paul Menzel. ( https://review.coreboot.org/c/coreboot/+/44018 )
Change subject: Doc/mb/facebook/monolith: Correct grammar by removing plural *s* ......................................................................
Doc/mb/facebook/monolith: Correct grammar by removing plural *s*
Change-Id: I2d14902f9d975e89cd2842f4c12eab8ca4018fbf Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M Documentation/mainboard/facebook/monolith.md 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/44018/4
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44018 )
Change subject: Doc/mb/facebook/monolith: Correct grammar by removing plural *s* ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44018/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44018/3//COMMIT_MSG@7 PS3, Line 7: grammatic
grammar
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44018 )
Change subject: Doc/mb/facebook/monolith: Correct grammar by removing plural *s* ......................................................................
Doc/mb/facebook/monolith: Correct grammar by removing plural *s*
Change-Id: I2d14902f9d975e89cd2842f4c12eab8ca4018fbf Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/44018 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/mainboard/facebook/monolith.md 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/Documentation/mainboard/facebook/monolith.md b/Documentation/mainboard/facebook/monolith.md index db8c246..022a4e5 100644 --- a/Documentation/mainboard/facebook/monolith.md +++ b/Documentation/mainboard/facebook/monolith.md @@ -2,7 +2,7 @@
This page describes how to run coreboot on the Facebook Monolith.
-Please note: the coreboot implementation for this boards is in its +Please note: the coreboot implementation for this board is in its Beta state and isn't fully tested yet.
## Required blobs
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)