Hung-Te Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43986 )
Change subject: mb/google/kukui: indent config names for burnet and esche ......................................................................
mb/google/kukui: indent config names for burnet and esche
The 'burnet' and 'esche' in Kcofig.name should have two spaces after the arrow.
BUG=None TEST=make menuconfig BRANCH=kukui
Change-Id: If7cc31cf459082a797445fb8223b3d9cbde72901 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig.name 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/43986/1
diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 77cdc67..ecfb86e 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -51,9 +51,9 @@ select BOARD_GOOGLE_JACUZZI_COMMON
config BOARD_GOOGLE_ESCHE - bool "-> Esche" + bool "-> Esche" select BOARD_GOOGLE_JACUZZI_COMMON
config BOARD_GOOGLE_BURNET - bool "-> Burnet" + bool "-> Burnet" select BOARD_GOOGLE_JACUZZI_COMMON
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43986 )
Change subject: mb/google/kukui: indent config names for burnet and esche ......................................................................
Patch Set 1: Code-Review+1
Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43986 )
Change subject: mb/google/kukui: indent config names for burnet and esche ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43986/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43986/1//COMMIT_MSG@9 PS1, Line 9: Kcofig Kconfig
Hello build bot (Jenkins), Jack Rosenthal, Paul Menzel, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43986
to look at the new patch set (#2).
Change subject: mb/google/kukui: indent config names for burnet and esche ......................................................................
mb/google/kukui: indent config names for burnet and esche
The 'burnet' and 'esche' in Kconfig.name should have two spaces after the arrow.
BUG=None TEST=make menuconfig BRANCH=kukui
Change-Id: If7cc31cf459082a797445fb8223b3d9cbde72901 Signed-off-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig.name 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/43986/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43986 )
Change subject: mb/google/kukui: indent config names for burnet and esche ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43986/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43986/1//COMMIT_MSG@9 PS1, Line 9: Kcofig
Kconfig
Done
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43986 )
Change subject: mb/google/kukui: indent config names for burnet and esche ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43986 )
Change subject: mb/google/kukui: indent config names for burnet and esche ......................................................................
mb/google/kukui: indent config names for burnet and esche
The 'burnet' and 'esche' in Kconfig.name should have two spaces after the arrow.
BUG=None TEST=make menuconfig BRANCH=kukui
Change-Id: If7cc31cf459082a797445fb8223b3d9cbde72901 Signed-off-by: Hung-Te Lin hungte@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/43986 Reviewed-by: Yu-Ping Wu yupingso@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Jack Rosenthal jrosenth@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/Kconfig.name 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Jack Rosenthal: Looks good to me, but someone else must approve Yu-Ping Wu: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 77cdc67..ecfb86e 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -51,9 +51,9 @@ select BOARD_GOOGLE_JACUZZI_COMMON
config BOARD_GOOGLE_ESCHE - bool "-> Esche" + bool "-> Esche" select BOARD_GOOGLE_JACUZZI_COMMON
config BOARD_GOOGLE_BURNET - bool "-> Burnet" + bool "-> Burnet" select BOARD_GOOGLE_JACUZZI_COMMON
-
Hung-Te Lin (Code Review) -
Jack Rosenthal (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Yu-Ping Wu (Code Review)