Change in coreboot[master]: mb/supermicro/x10slm-f: Add new superio support to board's Kconfig
Christoph Pomaska has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Add new superio support to board's Kconfig ...................................................................... mb/supermicro/x10slm-f: Add new superio support to board's Kconfig Since the superio support code didnt exist when the board was ported, the Kconfig was not modified yet to add support for the BMC-chip. This commit fixes the missing Kconfig entry. Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/1 diff --git a/src/mainboard/supermicro/x10slm-f/Kconfig b/src/mainboard/supermicro/x10slm-f/Kconfig index 3945c09..6effff2 100644 --- a/src/mainboard/supermicro/x10slm-f/Kconfig +++ b/src/mainboard/supermicro/x10slm-f/Kconfig @@ -20,15 +20,16 @@ def_bool y select BOARD_ROMSIZE_KB_16384 select CPU_INTEL_HASWELL - select DRIVERS_ASPEED_AST2050 # Supports AST2400 too. + select SOUTHBRIDGE_INTEL_LYNXPOINT select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select NORTHBRIDGE_INTEL_HASWELL select SERIRQ_CONTINUOUS_MODE - select SOUTHBRIDGE_INTEL_LYNXPOINT - select SUPERIO_NUVOTON_NCT6776 + select DRIVERS_ASPEED_AST2050 # Supports AST2400 too. + select SUPERIO_ASPEED_AST2400 # The board's BMC + select SUPERIO_NUVOTON_NCT6776 # the board's superio select SUPERIO_NUVOTON_NCT6776_COM_A config CBFS_SIZE -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 1 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-MessageType: newchange
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Add new superio support to board's Kconfig ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/34905/1//COMMIT_MSG@7 PS1, Line 7: mb/supermicro/x10slm-f: Add new superio support to board's Kconfig Character limit of 50 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 1 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Fri, 16 Aug 2019 22:43:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello Angel Pons, Tristan Corrick, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#2). Change subject: mb/supermicro/x10slm-f: Add ast2400 to Kconfig ...................................................................... mb/supermicro/x10slm-f: Add ast2400 to Kconfig Since the superio support code didnt exist when the board was ported, the Kconfig was not modified yet to add support for the BMC-chip. This commit fixes the missing Kconfig entry. Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 2 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Add ast2400 to Kconfig ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/34905/1//COMMIT_MSG@7 PS1, Line 7: mb/supermicro/x10slm-f: Add new superio support to board's Kconfig
Character limit of 50 Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 2 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 19 Aug 2019 07:19:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger@posteo.net> Gerrit-MessageType: comment
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Add ast2400 to Kconfig ...................................................................... Patch Set 2: Code-Review-1 You need to adapt the devicetree and early boot code for SoL, too. -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 2 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 19 Aug 2019 07:36:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#3). Change subject: mb/supermicro/x10slm-f: Add new superio support to board's Kconfig ...................................................................... mb/supermicro/x10slm-f: Add new superio support to board's Kconfig Since the superio support code didnt exist when the board was ported, the Kconfig was not modified yet to add support for the BMC-chip. This commit fixes the missing Kconfig entry. Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 3 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Add new superio support to board's Kconfig ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/3/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/Kconfig: https://review.coreboot.org/c/coreboot/+/34905/3/src/mainboard/supermicro/x1... PS3, Line 31: select SUPERIO_ASPEED_AST2400 # The board's BMC You need to adapt the devicetree and early boot code for SoL, too. -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 3 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 19 Aug 2019 08:50:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#4). Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... mb/supermicro/x10slm-f: Add new superio support to board's config Since the superio support code didnt exist when the board was ported, the Kconfig was not modified yet to add support for the BMC-chip. This commit fixes the missing Kconfig entry. Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x10slm-f/devicetree.cb 2 files changed, 50 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 4 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#5). Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... mb/supermicro/x10slm-f: Add new superio support to board's config Since the superio support code didnt exist when the board was ported, the Kconfig was not modified yet to add support for the BMC-chip. This commit fixes the missing Kconfig entry. Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x10slm-f/devicetree.cb 2 files changed, 48 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 5 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#6). Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... mb/supermicro/x10slm-f: Add new superio support to board's config Since the superio support code didnt exist when the board was ported, the Kconfig was not modified yet to add support for the BMC-chip. This commit fixes the missing Kconfig entry. Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x10slm-f/devicetree.cb 2 files changed, 50 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 6 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#7). Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... mb/supermicro/x10slm-f: Add new superio support to board's config Since the superio support code didnt exist when the board was ported, the Kconfig was not modified yet to add support for the BMC-chip. This commit fixes the missing Kconfig entry. Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x10slm-f/devicetree.cb 2 files changed, 48 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 7 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#8). Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... mb/supermicro/x10slm-f: Add new superio support to board's config Since the superio support code didnt exist when the board was ported, the Kconfig was not modified yet to add support for the BMC-chip. This commit fixes the missing Kconfig entry. At the moment the BMC is not being recognized by the ipmi_si kernel module Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x10slm-f/devicetree.cb 2 files changed, 48 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 8 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... Patch Set 8: (1 comment) The X10SLM+-F uses an NCT6776 as a super I/O to handle the serial port, etc. I briefly looked into the AST2400 providing super I/O functionality when I originally ported the board, but concluded that it isn't actually used as a super I/O. Have you been able to demonstrate otherwise? https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... PS8, Line 89: register "wait_for_bmc" = "1" Is it necessary to wait for full BMC init for super I/O to work? -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 8 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Sun, 01 Sep 2019 18:44:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... Patch Set 8:
Patch Set 8:
(1 comment)
The X10SLM+-F uses an NCT6776 as a super I/O to handle the serial port, etc. I briefly looked into the AST2400 providing super I/O functionality when I originally ported the board, but concluded that it isn't actually used as a super I/O. Have you been able to demonstrate otherwise?
I added the AST2400 driver hoping that it would fix the communication between the host and the BMC using the PCI interface which is broken at the moment. So far its not working yet. -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 8 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 01 Oct 2019 13:48:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... Patch Set 8: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... PS8, Line 5: ## Copyright (C) 2019 Hosting.de GmbH <c.pomaska@hosting.de> Will Hosting.de GmhH be copyright holder of this modification? -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 8 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-Comment-Date: Tue, 01 Oct 2019 14:01:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... Patch Set 8: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... PS8, Line 89: register "wait_for_bmc" = "1"
Is it necessary to wait for full BMC init for super I/O to work? As far as I can see it's not. Did not realize that it is not necessary for the BMC to work. Will be removed in the next patch set.
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 8 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 01 Oct 2019 15:26:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tristan Corrick <tristan@corrick.kiwi> Gerrit-MessageType: comment
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#9). Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... mb/supermicro/x10slm-f: Add new superio support to board's config Since the superio support code didnt exist when the board was ported, the Kconfig was not modified yet to add support for the BMC-chip. This commit fixes the missing Kconfig entry. At the moment the BMC is not being recognized by the ipmi_si kernel module Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x10slm-f/devicetree.cb 2 files changed, 46 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 9 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... Patch Set 9: Code-Review-1 (8 comments) https://review.coreboot.org/c/coreboot/+/34905/9//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/34905/9//COMMIT_MSG@11 PS9, Line 11: missing that's not why the commit does. It also adds support graphic init and IPMI https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... PS8, Line 89: register "wait_for_bmc" = "1"
As far as I can see it's not. Did not realize that it is not necessary for the BMC to work. […] That's unrelated to super I/O.
https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 88: chip drivers/ipmi needs "select IPMI_KCS" https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 89: device pnp ca2.0 on end how long does it take for the IPMI KCS service to start? On X11SSH it's 35 seconds after coreboot has entered ramstage. https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 94: device pnp 4e.0 off end doesn't exist https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 96: io 0x60 = 0xa00 missing lpc_gen_dec https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 113: io 0x60 = 0x3e8 missing lpc_gen_dec https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 117: io 0x60 = 0x2e8 missing lpc_gen_dec -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 9 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 01 Oct 2019 16:07:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Christoph Pomaska <github@aufmachen.jetzt> Comment-In-Reply-To: Tristan Corrick <tristan@corrick.kiwi> Gerrit-MessageType: comment
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#10). Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... mb/supermicro/x10slm-f: Add new superio support to board's config Since the superio support code didnt exist when the board was ported, the Kconfig was not modified yet to add support for the BMC-chip. This commit fixes the missing Kconfig entry. At the moment the BMC is not being recognized by the ipmi_si kernel module Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x10slm-f/devicetree.cb 2 files changed, 45 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 10 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... Patch Set 10: (2 comments) https://review.coreboot.org/c/coreboot/+/34905/9//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/34905/9//COMMIT_MSG@11 PS9, Line 11: missing
that's not why the commit does. […] I agree. The commit message is not accurate anymore.
https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... PS8, Line 5: ## Copyright (C) 2019 Hosting.de GmbH <c.pomaska@hosting.de>
Will Hosting. […] Yes.
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 10 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 01 Oct 2019 16:21:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org> Comment-In-Reply-To: Frans Hendriks <fhendriks@eltan.com> Gerrit-MessageType: comment
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... Patch Set 10: (2 comments) https://review.coreboot.org/c/coreboot/+/34905/3/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/Kconfig: https://review.coreboot.org/c/coreboot/+/34905/3/src/mainboard/supermicro/x1... PS3, Line 31: select SUPERIO_ASPEED_AST2400 # The board's BMC
You need to adapt the devicetree and early boot code for SoL, too. Done
https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 89: device pnp ca2.0 on end
how long does it take for the IPMI KCS service to start? On X11SSH it's 35 seconds after coreboot ha […] How did you measure it?
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 10 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 02 Oct 2019 07:47:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org> Gerrit-MessageType: comment
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Add new superio support to board's config ...................................................................... Patch Set 10: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 88: chip drivers/ipmi
needs "select IPMI_KCS" Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 10 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 07 Oct 2019 08:10:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org> Gerrit-MessageType: comment
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#11). Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... mb/supermicro/x10slm-f: Fix IPMI KCS This commit fixes the IPMI KCS communication between host and BMC on the X10SLM-F. Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x10slm-f/devicetree.cb 2 files changed, 49 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 11 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#12). Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... mb/supermicro/x10slm-f: Fix IPMI KCS This commit fixes the IPMI KCS communication between host and BMC on the X10SLM+-F. Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x10slm-f/devicetree.cb 2 files changed, 49 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 12 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 12: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... PS8, Line 5: ## Copyright (C) 2019 Hosting.de GmbH <c.pomaska@hosting.de>
Yes. Hm. IANAL, but is this valid, as it seems this whole block has been copied from x11ssh?
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 12 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 11 Oct 2019 21:49:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christoph Pomaska <github@aufmachen.jetzt> Comment-In-Reply-To: Frans Hendriks <fhendriks@eltan.com> Gerrit-MessageType: comment
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 12: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... PS8, Line 5: ## Copyright (C) 2019 Hosting.de GmbH <c.pomaska@hosting.de>
Hm. […] Honestly I have no idea. If there are people that have doubt that this is not an issue because it is actually copied from the X11 board, it's probably a good idea to remove this copyright remark. I don't want to get myself or the company I work for in any legal trouble obviously.
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 12 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 11 Oct 2019 22:34:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christoph Pomaska <github@aufmachen.jetzt> Comment-In-Reply-To: Michael Niewöhner Comment-In-Reply-To: Frans Hendriks <fhendriks@eltan.com> Gerrit-MessageType: comment
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 12: (3 comments) https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... PS8, Line 5: ## Copyright (C) 2019 Hosting.de GmbH <c.pomaska@hosting.de>
Honestly I have no idea. […] Usually we argue that copyright only applies to code and not to "config" files that have a predefined fixed pattern. Due to that most devicetree.cb, Makefile and Kconfig doesn't even include a copyright header.
https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... PS12, Line 55: register "gen1_dec" = "0x00000295" # Super I/O HWM that seems needed for the nct6776 0xb LDN. https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... PS12, Line 59: register "gen4_dec" = "0x00000000" 0x2e8 isn't routed to LPC but enabled on aspeed -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 12 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 12 Oct 2019 14:30:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christoph Pomaska <github@aufmachen.jetzt> Comment-In-Reply-To: Michael Niewöhner Comment-In-Reply-To: Frans Hendriks <fhendriks@eltan.com> Gerrit-MessageType: comment
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 12: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... PS8, Line 5: ## Copyright (C) 2019 Hosting.de GmbH <c.pomaska@hosting.de>
Usually we argue that copyright only applies to code and not to "config" files that have a predefine […] Well, it wouldn't be any problem if there was a Copyright on the original work. Then this Copyright would be copied, too, and another Copyright added. What I actually do not know is, if it is valid to add a Copyright header when there was none before, even when the code/config generally is GPL. TL;DR I really have no clue but I would remove the whole GPL header for the reason Patrick mentioned. AFAIK config can't be licensed at all (I may be wrong here...)
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 12 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 12 Oct 2019 16:24:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org> Comment-In-Reply-To: Christoph Pomaska <github@aufmachen.jetzt> Comment-In-Reply-To: Michael Niewöhner Comment-In-Reply-To: Frans Hendriks <fhendriks@eltan.com> Gerrit-MessageType: comment
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#13). Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... mb/supermicro/x10slm-f: Fix IPMI KCS This commit fixes the IPMI KCS communication between host and BMC on the X10SLM-F. Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x10slm-f/devicetree.cb 2 files changed, 48 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 13 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 13: (4 comments) https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... PS8, Line 5: ## Copyright (C) 2019 Hosting.de GmbH <c.pomaska@hosting.de>
Well, it wouldn't be any problem if there was a Copyright on the original work. […] Removed my copyright string in the latest patch set - problem solved I guess.
https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 96: io 0x60 = 0xa00
missing lpc_gen_dec Done
https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 113: io 0x60 = 0x3e8
missing lpc_gen_dec Done
https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 117: io 0x60 = 0x2e8
missing lpc_gen_dec Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 13 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 14 Oct 2019 07:54:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org> Comment-In-Reply-To: Christoph Pomaska <github@aufmachen.jetzt> Comment-In-Reply-To: Michael Niewöhner Comment-In-Reply-To: Frans Hendriks <fhendriks@eltan.com> Gerrit-MessageType: comment
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 13: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... PS12, Line 59: register "gen4_dec" = "0x00000000"
0x2e8 isn't routed to LPC but enabled on aspeed 0x2e is not the aspeed, but I assume that you mean the nct6776. In that case I agree that I could disable SUART4 on there.
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 13 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 14 Oct 2019 08:52:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org> Gerrit-MessageType: comment
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 13: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... PS12, Line 59: register "gen4_dec" = "0x00000000"
0x2e is not the aspeed, but I assume that you mean the nct6776. […] s/SUART4/WDT/
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 13 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 14 Oct 2019 08:57:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org> Comment-In-Reply-To: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-MessageType: comment
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 13: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... PS12, Line 59: register "gen4_dec" = "0x00000000"
s/SUART4/WDT/ 0x2e8 is on the aspeed. see 4e.c
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 13 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 14 Oct 2019 09:08:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org> Comment-In-Reply-To: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-MessageType: comment
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 13: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... PS12, Line 59: register "gen4_dec" = "0x00000000"
0x2e8 is on the aspeed. see 4e. […] Oh, I confused it with 2e.8 which is on nct6776.
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 13 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 14 Oct 2019 10:18:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org> Comment-In-Reply-To: Christoph Pomaska <github@aufmachen.jetzt> Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 13: (3 comments) https://review.coreboot.org/c/coreboot/+/34905/13//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/34905/13//COMMIT_MSG@10 PS13, Line 10: and BMC on the X10SLM-F. Please use the full text width of 75 characters. https://review.coreboot.org/c/coreboot/+/34905/13//COMMIT_MSG@11 PS13, Line 11: Please describe the problem, and the fix. https://review.coreboot.org/c/coreboot/+/34905/13/src/mainboard/supermicro/x... File src/mainboard/supermicro/x10slm-f/Kconfig: https://review.coreboot.org/c/coreboot/+/34905/13/src/mainboard/supermicro/x... PS13, Line 31: select SUPERIO_NUVOTON_NCT6776 # the board's superio Ordering changes and comments should be done in separate commits. -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 13 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 14 Oct 2019 13:32:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#14). Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... mb/supermicro/x10slm-f: Fix IPMI KCS This commit fixes the IPMI KCS communication between host and BMC on the X10SLM-F. Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x10slm-f/devicetree.cb 2 files changed, 45 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 14 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 14: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... PS12, Line 59: register "gen4_dec" = "0x00000000"
Oh, I confused it with 2e.8 which is on nct6776. Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 14 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 14 Oct 2019 14:01:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org> Comment-In-Reply-To: Christoph Pomaska <github@aufmachen.jetzt> Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-MessageType: comment
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 14: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/9/src/mainboard/supermicro/x1... PS9, Line 94: device pnp 4e.0 off end
doesn't exist Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 14 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 14 Oct 2019 14:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org> Gerrit-MessageType: comment
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#15). Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... mb/supermicro/x10slm-f: Fix IPMI KCS Because of missing generic LPC decode ranges the ipmi_si kernel module cannot communicate with the BMC. This commit fixes the IPMI KCS communication between host and BMC on the X10SLM-F. Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x10slm-f/devicetree.cb 2 files changed, 45 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 15 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 15: (2 comments) https://review.coreboot.org/c/coreboot/+/34905/13//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/34905/13//COMMIT_MSG@10 PS13, Line 10: and BMC on the X10SLM-F.
Please use the full text width of 75 characters. Done
https://review.coreboot.org/c/coreboot/+/34905/13//COMMIT_MSG@11 PS13, Line 11:
Please describe the problem, and the fix. Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 15 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 14 Oct 2019 14:21:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 15: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 15 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Comment-Date: Mon, 14 Oct 2019 14:56:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Paul Menzel, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#16). Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... mb/supermicro/x10slm-f: Fix IPMI KCS Because of missing generic LPC decode ranges the ipmi_si kernel module cannot communicate with the BMC. This commit fixes the IPMI KCS communication between host and BMC on the X10SLM-F. Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x10slm-f/devicetree.cb 2 files changed, 43 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/16 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 16 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-MessageType: newpatchset
Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 16: (1 comment) https://review.coreboot.org/c/coreboot/+/34905/13/src/mainboard/supermicro/x... File src/mainboard/supermicro/x10slm-f/Kconfig: https://review.coreboot.org/c/coreboot/+/34905/13/src/mainboard/supermicro/x... PS13, Line 31: select SUPERIO_NUVOTON_NCT6776 # the board's superio
Ordering changes and comments should be done in separate commits. Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 16 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Comment-Date: Tue, 15 Oct 2019 13:28:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment
Hello Patrick Rudolph, Angel Pons, Tristan Corrick, Paul Menzel, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34905 to look at the new patch set (#17). Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... mb/supermicro/x10slm-f: Fix IPMI KCS Because of missing generic LPC decode ranges the ipmi_si kernel module cannot communicate with the BMC. This commit fixes the IPMI KCS communication between host and BMC on the X10SLM-F. Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Signed-off-by: Christoph Pomaska <c.pomaska@hosting.de> --- M src/mainboard/supermicro/x10slm-f/Kconfig M src/mainboard/supermicro/x10slm-f/devicetree.cb 2 files changed, 44 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34905/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 17 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Michael Niewöhner Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-MessageType: newpatchset
Attention is currently required from: Christoph Pomaska. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 17: (2 comments) Patchset: PS17: Is this still needed? File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/comment/28f42fef_2889fb12 PS17, Line 117: device pnp 4e.c off # SUART4 missing `end` -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 17 Gerrit-Owner: Christoph Pomaska <github@slrie.de> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@slrie.de> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Michael Niewöhner <foss@mniewoehner.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Attention: Christoph Pomaska <github@slrie.de> Gerrit-Comment-Date: Mon, 15 Nov 2021 13:04:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34905?usp=email ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Abandoned This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author. -- To view, visit https://review.coreboot.org/c/coreboot/+/34905?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 17 Gerrit-Owner: Christoph Pomaska <github@slrie.de> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@slrie.de> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Martin L Roth <gaumless@gmail.com> Gerrit-CC: Michael Niewöhner <foss@mniewoehner.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-MessageType: abandon
participants (9)
-
Angel Pons (Code Review) -
Christoph Pomaska (Code Review)
-
Felix Singer (Code Review)
-
Frans Hendriks (Code Review)
-
Martin L Roth (Code Review)
-
Michael Niewöhner (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)
-
Tristan Corrick (Code Review)