Patch set 9:Code-Review -1

View Change

8 comments:

• Commit Message:

  • Patch Set #9, Line 11: missing

    that's not why the commit does. It also adds support graphic init and IPMI

• File src/mainboard/supermicro/x10slm-f/devicetree.cb:

  • Patch Set #8, Line 89: register "wait_for_bmc" = "1"

    As far as I can see it's not. Did not realize that it is not necessary for the BMC to work. […]

    That's unrelated to super I/O.

• File src/mainboard/supermicro/x10slm-f/devicetree.cb:

  • Patch Set #9, Line 88: chip drivers/ipmi

    needs "select IPMI_KCS"

  • Patch Set #9, Line 89: device pnp ca2.0 on end

    how long does it take for the IPMI KCS service to start? On X11SSH it's 35 seconds after coreboot has entered ramstage.

  • Patch Set #9, Line 94: device pnp 4e.0 off end

    doesn't exist

  • Patch Set #9, Line 96: io 0x60 = 0xa00

    missing lpc_gen_dec

  • Patch Set #9, Line 113: io 0x60 = 0x3e8

    missing lpc_gen_dec

  • Patch Set #9, Line 117: io 0x60 = 0x2e8

    missing lpc_gen_dec

To view, visit change 34905. To unsubscribe, or for help writing mail filters, visit settings.