Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 ) Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS ...................................................................... Patch Set 12: (3 comments) https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1... PS8, Line 5: ## Copyright (C) 2019 Hosting.de GmbH <c.pomaska@hosting.de>
Honestly I have no idea. […] Usually we argue that copyright only applies to code and not to "config" files that have a predefined fixed pattern. Due to that most devicetree.cb, Makefile and Kconfig doesn't even include a copyright header.
https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... File src/mainboard/supermicro/x10slm-f/devicetree.cb: https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... PS12, Line 55: register "gen1_dec" = "0x00000295" # Super I/O HWM that seems needed for the nct6776 0xb LDN. https://review.coreboot.org/c/coreboot/+/34905/12/src/mainboard/supermicro/x... PS12, Line 59: register "gen4_dec" = "0x00000000" 0x2e8 isn't routed to LPC but enabled on aspeed -- To view, visit https://review.coreboot.org/c/coreboot/+/34905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70 Gerrit-Change-Number: 34905 Gerrit-PatchSet: 12 Gerrit-Owner: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Christoph Pomaska <github@aufmachen.jetzt> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Frans Hendriks <fhendriks@eltan.com> Gerrit-CC: Michael Niewöhner Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sat, 12 Oct 2019 14:30:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christoph Pomaska <github@aufmachen.jetzt> Comment-In-Reply-To: Michael Niewöhner Comment-In-Reply-To: Frans Hendriks <fhendriks@eltan.com> Gerrit-MessageType: comment