Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42852 )
Change subject: sb/intel/i82801dx: Drop APM_CNT_MBI_UPDATE ......................................................................
sb/intel/i82801dx: Drop APM_CNT_MBI_UPDATE
No useful implementation existed.
Change-Id: I9a6f9876330fe9f0cdb2925e20f3675fda53d32b Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/southbridge/intel/i82801dx/smihandler.c 1 file changed, 0 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/42852/1
diff --git a/src/southbridge/intel/i82801dx/smihandler.c b/src/southbridge/intel/i82801dx/smihandler.c index 783e6d3..4f3ebd2 100644 --- a/src/southbridge/intel/i82801dx/smihandler.c +++ b/src/southbridge/intel/i82801dx/smihandler.c @@ -26,10 +26,6 @@ */ u16 pmbase = PMBASE_ADDR;
-unsigned char *mbi = NULL; -u32 mbi_len; -u8 mbi_initialized = 0; - /** * @brief read and clear PM1_STS * @return PM1_STS register @@ -337,17 +333,6 @@ outl(pmctrl, pmbase + PM1_CNT); printk(BIOS_DEBUG, "SMI#: ACPI enabled.\n"); break; - case APM_CNT_MBI_UPDATE: // FIXME - if (mbi_initialized) { - printk(BIOS_DEBUG, "SMI#: mbi already registered!\n"); - return; - } - mbi = *(void **)0x500; - mbi_len = *(u32 *)0x504; - mbi_initialized = 1; - printk(BIOS_DEBUG, "SMI#: Registered MBI at %p (%d bytes)\n", mbi, mbi_len); - break; - default: printk(BIOS_DEBUG, "SMI#: Unknown function APM_CNT=%02x\n", reg8); }
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42852 )
Change subject: sb/intel/i82801dx: Drop APM_CNT_MBI_UPDATE ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42852 )
Change subject: sb/intel/i82801dx: Drop APM_CNT_MBI_UPDATE ......................................................................
sb/intel/i82801dx: Drop APM_CNT_MBI_UPDATE
No useful implementation existed.
Change-Id: I9a6f9876330fe9f0cdb2925e20f3675fda53d32b Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42852 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/i82801dx/smihandler.c 1 file changed, 0 insertions(+), 15 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/southbridge/intel/i82801dx/smihandler.c b/src/southbridge/intel/i82801dx/smihandler.c index b54d1d39..af56941 100644 --- a/src/southbridge/intel/i82801dx/smihandler.c +++ b/src/southbridge/intel/i82801dx/smihandler.c @@ -24,10 +24,6 @@ */ u16 pmbase = PMBASE_ADDR;
-unsigned char *mbi = NULL; -u32 mbi_len; -u8 mbi_initialized = 0; - /** * @brief read and clear PM1_STS * @return PM1_STS register @@ -335,17 +331,6 @@ outl(pmctrl, pmbase + PM1_CNT); printk(BIOS_DEBUG, "SMI#: ACPI enabled.\n"); break; - case APM_CNT_MBI_UPDATE: // FIXME - if (mbi_initialized) { - printk(BIOS_DEBUG, "SMI#: mbi already registered!\n"); - return; - } - mbi = *(void **)0x500; - mbi_len = *(u32 *)0x504; - mbi_initialized = 1; - printk(BIOS_DEBUG, "SMI#: Registered MBI at %p (%d bytes)\n", mbi, mbi_len); - break; - default: printk(BIOS_DEBUG, "SMI#: Unknown function APM_CNT=%02x\n", reg8); }
-
Kyösti Mälkki (Code Review) -
Patrick Georgi (Code Review)