Kyösti Mälkki has uploaded this change for review.

View Change

sb/intel/i82801dx: Drop APM_CNT_MBI_UPDATE

No useful implementation existed.

Change-Id: I9a6f9876330fe9f0cdb2925e20f3675fda53d32b
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
---
M src/southbridge/intel/i82801dx/smihandler.c
1 file changed, 0 insertions(+), 15 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/42852/1
diff --git a/src/southbridge/intel/i82801dx/smihandler.c b/src/southbridge/intel/i82801dx/smihandler.c
index 783e6d3..4f3ebd2 100644
--- a/src/southbridge/intel/i82801dx/smihandler.c
+++ b/src/southbridge/intel/i82801dx/smihandler.c
@@ -26,10 +26,6 @@
*/
u16 pmbase = PMBASE_ADDR;

-unsigned char *mbi = NULL;
-u32 mbi_len;
-u8 mbi_initialized = 0;
-
/**
* @brief read and clear PM1_STS
* @return PM1_STS register
@@ -337,17 +333,6 @@
outl(pmctrl, pmbase + PM1_CNT);
printk(BIOS_DEBUG, "SMI#: ACPI enabled.\n");
break;
- case APM_CNT_MBI_UPDATE: // FIXME
- if (mbi_initialized) {
- printk(BIOS_DEBUG, "SMI#: mbi already registered!\n");
- return;
- }
- mbi = *(void **)0x500;
- mbi_len = *(u32 *)0x504;
- mbi_initialized = 1;
- printk(BIOS_DEBUG, "SMI#: Registered MBI at %p (%d bytes)\n", mbi, mbi_len);
- break;
-
default:
printk(BIOS_DEBUG, "SMI#: Unknown function APM_CNT=%02x\n", reg8);
}

To view, visit change 42852. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a6f9876330fe9f0cdb2925e20f3675fda53d32b
Gerrit-Change-Number: 42852
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-MessageType: newchange