Attention is currently required from: Ravi kumar. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57449 )
Change subject: Herobrine: sc7280: Add support for audio ......................................................................
Patch Set 20:
(3 comments)
File src/mainboard/google/herobrine/board.h:
https://review.coreboot.org/c/coreboot/+/57449/comment/f581f01c_fc65fce1 PS20, Line 33: one more tab
File src/mainboard/google/herobrine/chromeos.c:
https://review.coreboot.org/c/coreboot/+/57449/comment/3807b359_18c75f63 PS20, Line 19: gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULL_UP); TPM configuration should be in a separate CL
https://review.coreboot.org/c/coreboot/+/57449/comment/7e817ead_d2b79bd6 PS20, Line 32: {GPIO_H1_AP_INT.addr, ACTIVE_HIGH, gpio_get(GPIO_H1_AP_INT), Same comment as above.