Attention is currently required from: Ravi kumar.

View Change

3 comments:

• File src/mainboard/google/herobrine/board.h:

  • Patch Set #20, Line 33:

    one more tab

• File src/mainboard/google/herobrine/chromeos.c:

  • Patch Set #20, Line 19: gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULL_UP);

    TPM configuration should be in a separate CL

  • Patch Set #20, Line 32: {GPIO_H1_AP_INT.addr, ACTIVE_HIGH, gpio_get(GPIO_H1_AP_INT),

    Same comment as above.

To view, visit change 57449. To unsubscribe, or for help writing mail filters, visit settings.