Change in coreboot[master]: mb/facebook/monolith: Enable HDA for HDMI output

[Wim Vervoorn (Code Review)]

Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38128 )

Change subject: mb/facebook/monolith: Enable HDA for HDMI output
......................................................................

mb/facebook/monolith: Enable HDA for HDMI output

The HDA controller was disabed as there is not HDA codec in the system.
Because of this there is no audio support if an HDMI monitor is
connected.

Enable Azalia and enable the HDA device in the device tree.

BUG=N/A
TEST=tested on facebook monolith

Change-Id: I7be2c29151dc9d6c247c3332fb9adfb34449c703
Signed-off-by: Wim Vervoorn 
---
M src/mainboard/facebook/monolith/devicetree.cb
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/38128/1

diff --git a/src/mainboard/facebook/monolith/devicetree.cb b/src/mainboard/facebook/monolith/devicetree.cb
index b5e3191..f715eb3 100644
--- a/src/mainboard/facebook/monolith/devicetree.cb
+++ b/src/mainboard/facebook/monolith/devicetree.cb
@@ -28,7 +28,7 @@
    register "dptf_enable" = "0"

# FSP Configuration
-	register "EnableAzalia" = "0"
+	register "EnableAzalia" = "1"
    register "SmbusEnable" = "1"
    register "ScsEmmcEnabled" = "1"
    register "ScsEmmcHs400Enabled" = "1"
@@ -240,6 +240,7 @@
    	end # LPC Bridge
    	device pci 1f.1 on  end # P2SB
    	device pci 1f.2 on  end # Power Management Controller
+		device pci 1f.3 on  end # HDA Controller for HDMI only
    	device pci 1f.4 on  end # SMBus
    	device pci 1f.5 on  end # PCH SPI
    	device pci 1f.6 on  end # GbE

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38128 )

Change subject: mb/facebook/monolith: Enable HDA for HDMI output
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38128 )

Change subject: mb/facebook/monolith: Enable HDA for HDMI output
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/38128/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38128/1//COMMIT_MSG@10 
PS1, Line 10: Because of this there is no audio support if an HDMI monitor is
I'm confused: does audio over HDMI work now or not?

Maybe rephrase this part a bit:

The HDA controller was disabled because no codec exists on the board. However, this also disabled audio over HDMI.

To correct this, enable Azalia and the HDA controller in the devicetree.

[Wim Vervoorn (Code Review)]

Hello Angel Pons, Frans Hendriks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38128

to look at the new patch set (#2).

Change subject: mb/facebook/monolith: Enable HDA for HDMI output
......................................................................

mb/facebook/monolith: Enable HDA for HDMI output

The HDA controller was disabled because no codec exists on the board. However, this also disabled
audio over HDMI.

To correct this, enable Azalia and the HDA controller in the devicetree.

BUG=N/A
TEST=tested on facebook monolith

Change-Id: I7be2c29151dc9d6c247c3332fb9adfb34449c703
Signed-off-by: Wim Vervoorn 
---
M src/mainboard/facebook/monolith/devicetree.cb
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/38128/2

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38128 )

Change subject: mb/facebook/monolith: Enable HDA for HDMI output
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38128/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38128/1//COMMIT_MSG@10 
PS1, Line 10: Because of this there is no audio support if an HDMI monitor is
> I'm confused: does audio over HDMI work now or not? […]

Done

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38128 )

Change subject: mb/facebook/monolith: Enable HDA for HDMI output
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38128/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38128/2//COMMIT_MSG@9 
PS2, Line 9: The HDA controller was disabled because no codec exists on the board. However, this also disabled
Please wrap the line.

[Wim Vervoorn (Code Review)]

Hello Angel Pons, Frans Hendriks, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38128

to look at the new patch set (#3).

Change subject: mb/facebook/monolith: Enable HDA for HDMI output
......................................................................

mb/facebook/monolith: Enable HDA for HDMI output

The HDA controller was disabled because no codec exists on the board.
However, this also disabled audio over HDMI.

To correct this, enable Azalia and the HDA controller in the devicetree.

BUG=N/A
TEST=tested on facebook monolith

Change-Id: I7be2c29151dc9d6c247c3332fb9adfb34449c703
Signed-off-by: Wim Vervoorn 
---
M src/mainboard/facebook/monolith/devicetree.cb
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/38128/3

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38128 )

Change subject: mb/facebook/monolith: Enable HDA for HDMI output
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38128/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38128/2//COMMIT_MSG@9 
PS2, Line 9: The HDA controller was disabled because no codec exists on the board. However, this also disabled
> Please wrap the line.

Done

[Nico Huber (Code Review)]

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38128 )

Change subject: mb/facebook/monolith: Enable HDA for HDMI output
......................................................................

mb/facebook/monolith: Enable HDA for HDMI output

The HDA controller was disabled because no codec exists on the board.
However, this also disabled audio over HDMI.

To correct this, enable Azalia and the HDA controller in the devicetree.

BUG=N/A
TEST=tested on facebook monolith

Change-Id: I7be2c29151dc9d6c247c3332fb9adfb34449c703
Signed-off-by: Wim Vervoorn 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38128
Tested-by: build bot (Jenkins) 
Reviewed-by: Frans Hendriks 
Reviewed-by: Angel Pons 
---
M src/mainboard/facebook/monolith/devicetree.cb
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Frans Hendriks: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/facebook/monolith/devicetree.cb b/src/mainboard/facebook/monolith/devicetree.cb
index 85052ec..3fb5cba 100644
--- a/src/mainboard/facebook/monolith/devicetree.cb
+++ b/src/mainboard/facebook/monolith/devicetree.cb
@@ -26,7 +26,7 @@
    register "dptf_enable" = "0"

# FSP Configuration
-	register "EnableAzalia" = "0"
+	register "EnableAzalia" = "1"
    register "SmbusEnable" = "1"
    register "ScsEmmcEnabled" = "1"
    register "ScsEmmcHs400Enabled" = "1"
@@ -238,6 +238,7 @@
    	end # LPC Bridge
    	device pci 1f.1 on  end # P2SB
    	device pci 1f.2 on  end # Power Management Controller
+		device pci 1f.3 on  end # HDA Controller for HDMI only
    	device pci 1f.4 on  end # SMBus
    	device pci 1f.5 on  end # PCH SPI
    	device pci 1f.6 on  end # GbE