Change in coreboot[master]: fsp1_1: Drop unused weak function

[Nico Huber (Code Review)]

Hello Wim Vervoorn,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/38138

to review the following change.

Change subject: fsp1_1: Drop unused weak function
......................................................................

fsp1_1: Drop unused weak function

All FSP 1.1 platforms override the weak soc_load_logo().

Change-Id: Ib2eae166e02771311c50ea7e4f294790dfa2b99e
Signed-off-by: Nico Huber 
---
M src/drivers/intel/fsp1_1/ramstage.c
1 file changed, 0 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/38138/1

diff --git a/src/drivers/intel/fsp1_1/ramstage.c b/src/drivers/intel/fsp1_1/ramstage.c
index 40e79cc..05a29cb 100644
--- a/src/drivers/intel/fsp1_1/ramstage.c
+++ b/src/drivers/intel/fsp1_1/ramstage.c
@@ -209,9 +209,3 @@
 __weak void soc_silicon_init_params(SILICON_INIT_UPD *params)
 {
 }
-
-/* Load bmp and set FSP parameters, fsp_load_logo can be used */
-__weak const struct cbmem_entry *soc_load_logo(SILICON_INIT_UPD *params)
-{
-	return NULL;
-}

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38138 )

Change subject: fsp1_1: Drop unused weak function
......................................................................

Patch Set 1: Code-Review+2

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38138 )

Change subject: fsp1_1: Drop unused weak function
......................................................................

Patch Set 1: Code-Review+1

[Nico Huber (Code Review)]

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38138 )

Change subject: fsp1_1: Drop unused weak function
......................................................................

fsp1_1: Drop unused weak function

All FSP 1.1 platforms override the weak soc_load_logo().

Change-Id: Ib2eae166e02771311c50ea7e4f294790dfa2b99e
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38138
Reviewed-by: Subrata Banik 
Reviewed-by: Wim Vervoorn 
Tested-by: build bot (Jenkins) 
---
M src/drivers/intel/fsp1_1/ramstage.c
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Wim Vervoorn: Looks good to me, but someone else must approve
  Subrata Banik: Looks good to me, approved

diff --git a/src/drivers/intel/fsp1_1/ramstage.c b/src/drivers/intel/fsp1_1/ramstage.c
index 40e79cc..05a29cb 100644
--- a/src/drivers/intel/fsp1_1/ramstage.c
+++ b/src/drivers/intel/fsp1_1/ramstage.c
@@ -209,9 +209,3 @@
 __weak void soc_silicon_init_params(SILICON_INIT_UPD *params)
 {
 }
-
-/* Load bmp and set FSP parameters, fsp_load_logo can be used */
-__weak const struct cbmem_entry *soc_load_logo(SILICON_INIT_UPD *params)
-{
-	return NULL;
-}