Change in coreboot[master]: mb/facebook/monolith: Remove unused SDIO controller from devicetree
Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38129 )
Change subject: mb/facebook/monolith: Remove unused SDIO controller from devicetree ......................................................................
mb/facebook/monolith: Remove unused SDIO controller from devicetree
The SDIO device is disabled so remove it from the devicetree.
BUG=N/A TEST=build
Change-Id: I6497f6134d8fc001bf4cb7e348ae00077aa34814 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/38129/1
diff --git a/src/mainboard/facebook/monolith/devicetree.cb b/src/mainboard/facebook/monolith/devicetree.cb index f715eb3..dbe36f0 100644 --- a/src/mainboard/facebook/monolith/devicetree.cb +++ b/src/mainboard/facebook/monolith/devicetree.cb @@ -232,7 +232,6 @@ device pci 1d.0 on end # PCI Express Port 9 x4 FPGA device pci 1e.0 on end # UART #0 device pci 1e.4 on end # eMMC - device pci 1e.5 off end # SDIO device pci 1f.0 on # LPC Interface chip drivers/pc80/tpm device pnp 0c31.0 on end
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38129 )
Change subject: mb/facebook/monolith: Remove unused SDIO controller from devicetree ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38129/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38129/1//COMMIT_MSG@7 PS1, Line 7: mb/facebook/monolith: Remove unused SDIO controller from devicetree 'Remove SDIO controller from devicetree'
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38129
to look at the new patch set (#2).
Change subject: mb/facebook/monolith: Remove SDIO controller from devicetree ......................................................................
mb/facebook/monolith: Remove SDIO controller from devicetree
The SDIO device is disabled so remove it from the devicetree.
BUG=N/A TEST=build
Change-Id: I6497f6134d8fc001bf4cb7e348ae00077aa34814 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/38129/2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38129 )
Change subject: mb/facebook/monolith: Remove SDIO controller from devicetree ......................................................................
Patch Set 2: Code-Review+2
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38129 )
Change subject: mb/facebook/monolith: Remove SDIO controller from devicetree ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38129/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38129/1//COMMIT_MSG@7 PS1, Line 7: mb/facebook/monolith: Remove unused SDIO controller from devicetree
'Remove SDIO controller from devicetree'
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38129 )
Change subject: mb/facebook/monolith: Remove SDIO controller from devicetree ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38129/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38129/2//COMMIT_MSG@12 PS2, Line 12: TEST=build Have you checked if it remains disabled after booting?
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38129 )
Change subject: mb/facebook/monolith: Remove SDIO controller from devicetree ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38129/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38129/2//COMMIT_MSG@12 PS2, Line 12: TEST=build
Have you checked if it remains disabled after booting?
I checked it and it remains disabled.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38129 )
Change subject: mb/facebook/monolith: Remove SDIO controller from devicetree ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38129/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38129/2//COMMIT_MSG@12 PS2, Line 12: TEST=build
I checked it and it remains disabled.
Ack
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38129 )
Change subject: mb/facebook/monolith: Remove SDIO controller from devicetree ......................................................................
mb/facebook/monolith: Remove SDIO controller from devicetree
The SDIO device is disabled so remove it from the devicetree.
BUG=N/A TEST=build
Change-Id: I6497f6134d8fc001bf4cb7e348ae00077aa34814 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38129 Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/facebook/monolith/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/facebook/monolith/devicetree.cb b/src/mainboard/facebook/monolith/devicetree.cb index 3fb5cba..4a34cab 100644 --- a/src/mainboard/facebook/monolith/devicetree.cb +++ b/src/mainboard/facebook/monolith/devicetree.cb @@ -230,7 +230,6 @@ device pci 1d.0 on end # PCI Express Port 9 x4 FPGA device pci 1e.0 on end # UART #0 device pci 1e.4 on end # eMMC - device pci 1e.5 off end # SDIO device pci 1f.0 on # LPC Interface chip drivers/pc80/tpm device pnp 0c31.0 on end
-
Angel Pons (Code Review) -
Frans Hendriks (Code Review)
-
Nico Huber (Code Review)
-
Wim Vervoorn (Code Review)