Nico Huber submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved Angel Pons: Looks good to me, approved
mb/facebook/monolith: Enable HDA for HDMI output

The HDA controller was disabled because no codec exists on the board.
However, this also disabled audio over HDMI.

To correct this, enable Azalia and the HDA controller in the devicetree.

BUG=N/A
TEST=tested on facebook monolith

Change-Id: I7be2c29151dc9d6c247c3332fb9adfb34449c703
Signed-off-by: Wim Vervoorn <wvervoorn@eltan.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38128
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Frans Hendriks <fhendriks@eltan.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M src/mainboard/facebook/monolith/devicetree.cb
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/facebook/monolith/devicetree.cb b/src/mainboard/facebook/monolith/devicetree.cb
index 85052ec..3fb5cba 100644
--- a/src/mainboard/facebook/monolith/devicetree.cb
+++ b/src/mainboard/facebook/monolith/devicetree.cb
@@ -26,7 +26,7 @@
register "dptf_enable" = "0"

# FSP Configuration
- register "EnableAzalia" = "0"
+ register "EnableAzalia" = "1"
register "SmbusEnable" = "1"
register "ScsEmmcEnabled" = "1"
register "ScsEmmcHs400Enabled" = "1"
@@ -238,6 +238,7 @@
end # LPC Bridge
device pci 1f.1 on end # P2SB
device pci 1f.2 on end # Power Management Controller
+ device pci 1f.3 on end # HDA Controller for HDMI only
device pci 1f.4 on end # SMBus
device pci 1f.5 on end # PCH SPI
device pci 1f.6 on end # GbE

To view, visit change 38128. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7be2c29151dc9d6c247c3332fb9adfb34449c703
Gerrit-Change-Number: 38128
Gerrit-PatchSet: 4
Gerrit-Owner: Wim Vervoorn <wvervoorn@eltan.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn@eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged