Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/19911 )
Change subject: soc/intel/common: Add common Intel timer code
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/19911/2/src/soc/intel/common/block/timer/tim...
File src/soc/intel/common/block/timer/timer.c:
Line 21: #define CPU_BCLK 100
I saw this define in the common cpu CL.
Ok.Do you suggest on using definition from intelblocks/cpu.h,
Did not use that as it would expose function declarations under cpu.h here and it would not be used.
--
To view, visit
https://review.coreboot.org/19911
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd4b24735c74c636348fc32afbcc267e384cb610
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-HasComments: Yes