Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/19912 )
Change subject: soc/intel/skylake: Use Intel timer common code
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/19912/4/src/soc/intel/skylake/Kconfig
File src/soc/intel/skylake/Kconfig:
PS4, Line 164: PCR_BASE_ADDRESS
Why isn't this option deleted completely? It's also not even being used asi
Done.Removed references to this config from mainboard in this patch https://review.coreboot.org/#/c/20002/1. please review.
--
To view, visit
https://review.coreboot.org/19912
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fad620b11c9e5db128f646639c79ea58a0a574f
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-HasComments: Yes