Attention is currently required from: Raul Rangel, Tim Wawrzynczak, Karthik Ramasubramanian.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63212 )
Change subject: mb/google/octopus: Implement touchscreen,digitizer power sequencing
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63212/comment/c5928fee_a0af4d0e
PS2, Line 10: bootblock
We won't be able to backport this to the existing firmware will we? Bootblock is in RO for all relea […]
not unless there's another way to set the enable/reset/stop GPIOs in sequence and with sufficient delay such that the touchscreens are all reliably detected during SSDT generation. I'm certainly open to alternative implementations, this is just what Tim and I came up with and it works reliably AFAICT
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63212
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia725b4054069c0a4f60afd7e0bca6e2fd5fdcbba
Gerrit-Change-Number: 63212
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 01 Apr 2022 02:15:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment