Change in coreboot[master]: drivers/i2c/generic: Add support for i2c device detection

Attention is currently required from: Raul Rangel, Tim Wawrzynczak, Karthik Ramasubramanian. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63211 ) Change subject: drivers/i2c/generic: Add support for i2c device detection ...................................................................... Patch Set 3: (2 comments) File src/drivers/i2c/generic/generic.c: https://review.coreboot.org/c/coreboot/+/63211/comment/f4ddc769_66c1310b PS1, Line 73: if (!detected)
I would add a message here, saying that no ACPI entry is being created for this device b/c it was no […] Done
https://review.coreboot.org/c/coreboot/+/63211/comment/9d491832_0701ae69 PS1, Line 71: bool detected = busdev->ops->ops_i2c_bus->detect(busdev, : dev->path.i2c.device); : if (!detected) : return;
make sure to check `busdev` and the `detect` fn pointer aren't NULL, too, (maybe more prints too) e. […] Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/63211 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a4169ed6416d544773a37d29cdcc154d3c28519 Gerrit-Change-Number: 63211 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Attention: Raul Rangel <rrangel@chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com> Gerrit-Comment-Date: Fri, 01 Apr 2022 02:10:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-MessageType: comment
participants (1)
-
Matt DeVillier (Code Review)