Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44225 )
Change subject: include/cpu/x86/cache.h: Rename include guard ......................................................................
include/cpu/x86/cache.h: Rename include guard
Change-Id: Ibe4d9ff696755f4326509b6307c5a4dcca81ec4c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/include/cpu/x86/cache.h 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/44225/1
diff --git a/src/include/cpu/x86/cache.h b/src/include/cpu/x86/cache.h index 01b202e..b272a42 100644 --- a/src/include/cpu/x86/cache.h +++ b/src/include/cpu/x86/cache.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#ifndef CPU_X86_CACHE -#define CPU_X86_CACHE +#ifndef __CPU_X86_CACHE__ +#define __CPU_X86_CACHE__
#include <cpu/x86/cr.h>
@@ -57,4 +57,4 @@ void x86_enable_cache(void);
#endif /* !__ASSEMBLER__ */ -#endif /* CPU_X86_CACHE */ +#endif /* __CPU_X86_CACHE__ */
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44225
to look at the new patch set (#3).
Change subject: include/cpu/x86/cache.h: Rename include guard ......................................................................
include/cpu/x86/cache.h: Rename include guard
Change-Id: Ibe4d9ff696755f4326509b6307c5a4dcca81ec4c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/include/cpu/x86/cache.h 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/44225/3
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44225 )
Change subject: include/cpu/x86/cache.h: Rename include guard ......................................................................
Patch Set 4: Code-Review+2
Hello build bot (Jenkins), Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44225
to look at the new patch set (#5).
Change subject: include/cpu/x86/cache.h: Rename include guard ......................................................................
include/cpu/x86/cache.h: Rename include guard
Change-Id: Ibe4d9ff696755f4326509b6307c5a4dcca81ec4c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/include/cpu/x86/cache.h 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/44225/5
Hello build bot (Jenkins), Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44225
to look at the new patch set (#6).
Change subject: include/cpu/x86/cache.h: Rename include guard ......................................................................
include/cpu/x86/cache.h: Rename include guard
A Kconfig option with the same name will be added soon. So, rename this to avoid potential confusion and for consistency with other headers.
Change-Id: Ibe4d9ff696755f4326509b6307c5a4dcca81ec4c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/include/cpu/x86/cache.h 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/44225/6
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44225 )
Change subject: include/cpu/x86/cache.h: Rename include guard ......................................................................
Abandoned
Sorry, I ran out of patience and energy to care about these changes any longer.
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)