Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43990 )
Change subject: mb/google/zork: Add Samsung Samsung K4AAG165WA-BCTD SPD ......................................................................
mb/google/zork: Add Samsung Samsung K4AAG165WA-BCTD SPD
For dirinboz DRAMID 0x9: H5AN8G6NDJR-XNC
BUG=b:161579679 BRANCH=master TEST=build Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: I28c0d23f96c5b9c975ffead3a1cac66cbda8c293 --- A src/mainboard/google/zork/spd/samsung-K4AAG165WA-BCTD.spd.hex 1 file changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/43990/1
diff --git a/src/mainboard/google/zork/spd/samsung-K4AAG165WA-BCTD.spd.hex b/src/mainboard/google/zork/spd/samsung-K4AAG165WA-BCTD.spd.hex new file mode 100644 index 0000000..71b05a2 --- /dev/null +++ b/src/mainboard/google/zork/spd/samsung-K4AAG165WA-BCTD.spd.hex @@ -0,0 +1,33 @@ +# Samsung K4AAG165WA-BCWE +23 11 0C 03 46 29 00 08 00 60 00 03 02 03 00 00 +00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 F7 4B +0F 11 02 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 DB 08 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 CE 00 00 00 00 00 00 00 4B 34 41 41 47 31 36 +35 57 41 2D 42 43 54 44 20 20 20 20 20 00 80 CE +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Kevin Chiu has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/43990 )
Change subject: mb/google/zork: Add Samsung Samsung K4AAG165WA-BCTD SPD ......................................................................
mb/google/zork: Add Samsung Samsung K4AAG165WA-BCTD SPD
For dirinboz DRAMID 0x9: K4AAG165WA-BCTD
BUG=b:161579679 BRANCH=master TEST=build Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: I28c0d23f96c5b9c975ffead3a1cac66cbda8c293 --- A src/mainboard/google/zork/spd/samsung-K4AAG165WA-BCTD.spd.hex 1 file changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/43990/2
Hello build bot (Jenkins), Martin Roth, Patrick Georgi, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43990
to look at the new patch set (#3).
Change subject: mb/google/zork: Add Samsung K4AAG165WA-BCTD SPD ......................................................................
mb/google/zork: Add Samsung K4AAG165WA-BCTD SPD
For dirinboz DRAMID 0x9: K4AAG165WA-BCTD
BUG=b:161579679 BRANCH=master TEST=build Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: I28c0d23f96c5b9c975ffead3a1cac66cbda8c293 --- A src/mainboard/google/zork/spd/samsung-K4AAG165WA-BCTD.spd.hex 1 file changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/43990/3
Hello build bot (Jenkins), Martin Roth, Patrick Georgi, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43990
to look at the new patch set (#4).
Change subject: mb/google/zork: Add Samsung K4AAG165WA-BCTD SPD ......................................................................
mb/google/zork: Add Samsung K4AAG165WA-BCTD SPD
For dirinboz DRAMID 0x9: K4AAG165WA-BCTD
BUG=b:161579679 BRANCH=master TEST=build
Change-Id: I28c0d23f96c5b9c975ffead3a1cac66cbda8c293 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- A src/mainboard/google/zork/spd/samsung-K4AAG165WA-BCTD.spd.hex 1 file changed, 33 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/43990/4
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43990 )
Change subject: mb/google/zork: Add Samsung K4AAG165WA-BCTD SPD ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43990 )
Change subject: mb/google/zork: Add Samsung K4AAG165WA-BCTD SPD ......................................................................
mb/google/zork: Add Samsung K4AAG165WA-BCTD SPD
For dirinboz DRAMID 0x9: K4AAG165WA-BCTD
BUG=b:161579679 BRANCH=master TEST=build
Change-Id: I28c0d23f96c5b9c975ffead3a1cac66cbda8c293 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43990 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- A src/mainboard/google/zork/spd/samsung-K4AAG165WA-BCTD.spd.hex 1 file changed, 33 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/google/zork/spd/samsung-K4AAG165WA-BCTD.spd.hex b/src/mainboard/google/zork/spd/samsung-K4AAG165WA-BCTD.spd.hex new file mode 100644 index 0000000..f747f7c --- /dev/null +++ b/src/mainboard/google/zork/spd/samsung-K4AAG165WA-BCTD.spd.hex @@ -0,0 +1,33 @@ +# Samsung K4AAG165WA-BCTD +23 11 0C 03 46 29 00 08 00 60 00 03 02 03 00 00 +00 00 06 0D F8 3F 00 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 F7 4B +0F 11 02 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 DB 08 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 CE 00 00 00 00 00 00 00 4B 34 41 41 47 31 36 +35 57 41 2D 42 43 54 44 20 20 20 20 20 00 80 CE +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
-
Kevin Chiu (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)