Change in coreboot[master]: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad
David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43998 )
Change subject: mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad ......................................................................
mb/google/volteer/var/terrador: Support ELAN i2c-hid touchpad
Update ELAN i2c-hid touchpad configuration
BUG=b:160741785 BRANCH=None TEST=Verify touchpad is working fine.
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I2549048766d0707666910bd86c46ac9201bf3905 --- M src/mainboard/google/volteer/variants/todor/overridetree.cb 1 file changed, 7 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/43998/1
diff --git a/src/mainboard/google/volteer/variants/todor/overridetree.cb b/src/mainboard/google/volteer/variants/todor/overridetree.cb index c1c386a..8c0fb38 100644 --- a/src/mainboard/google/volteer/variants/todor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/todor/overridetree.cb @@ -117,12 +117,13 @@ end end # I2C2 0xA0EA device pci 19.1 on - chip drivers/i2c/generic - register "hid" = ""ELAN0000"" - register "desc" = ""ELAN Touchpad"" - register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_E15_IRQ)" - register "wake" = "GPE0_DW2_15" - register "probed" = "1" + chip drivers/i2c/hid + register "generic.hid" = ""ELAN2700"" + register "generic.desc" = ""ELAN Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_E15_IRQ)" + register "generic.wake" = "GPE0_DW2_15" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x01" device i2c 15 on end end end # I2C5 0xA0C6
Hello YH Lin, Caveh Jalali, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43998
to look at the new patch set (#2).
Change subject: mb/google/volteer/var/todor: Support ELAN i2c-hid touchpad ......................................................................
mb/google/volteer/var/todor: Support ELAN i2c-hid touchpad
Update ELAN i2c-hid touchpad configuration
BUG=b:160741785 BRANCH=None TEST=Verify touchpad is working fine.
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I2549048766d0707666910bd86c46ac9201bf3905 --- M src/mainboard/google/volteer/variants/todor/overridetree.cb 1 file changed, 7 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/43998/2
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43998 )
Change subject: mb/google/volteer/var/todor: Support ELAN i2c-hid touchpad ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43998 )
Change subject: mb/google/volteer/var/todor: Support ELAN i2c-hid touchpad ......................................................................
mb/google/volteer/var/todor: Support ELAN i2c-hid touchpad
Update ELAN i2c-hid touchpad configuration
BUG=b:160741785 BRANCH=None TEST=Verify touchpad is working fine.
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I2549048766d0707666910bd86c46ac9201bf3905 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43998 Reviewed-by: Caveh Jalali caveh@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/todor/overridetree.cb 1 file changed, 7 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/todor/overridetree.cb b/src/mainboard/google/volteer/variants/todor/overridetree.cb index c1c386a..8c0fb38 100644 --- a/src/mainboard/google/volteer/variants/todor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/todor/overridetree.cb @@ -117,12 +117,13 @@ end end # I2C2 0xA0EA device pci 19.1 on - chip drivers/i2c/generic - register "hid" = ""ELAN0000"" - register "desc" = ""ELAN Touchpad"" - register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_E15_IRQ)" - register "wake" = "GPE0_DW2_15" - register "probed" = "1" + chip drivers/i2c/hid + register "generic.hid" = ""ELAN2700"" + register "generic.desc" = ""ELAN Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_E15_IRQ)" + register "generic.wake" = "GPE0_DW2_15" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x01" device i2c 15 on end end end # I2C5 0xA0C6
-
Caveh Jalali (Code Review) -
David Wu (Code Review)
-
Patrick Georgi (Code Review)