Change in ...coreboot[master]: util/arm_boot_tools/mksunxiboot: Correct format string for longs
Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32008
Change subject: util/arm_boot_tools/mksunxiboot: Correct format string for longs ......................................................................
util/arm_boot_tools/mksunxiboot: Correct format string for longs
%lx is the right format string for printing longs. Fixes Coverity CID 1229686, 1229687
Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: Ib7ab54dc039bdd60969c79f3c881d69fc68f0d2a --- M util/arm_boot_tools/mksunxiboot/mksunxiboot.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/32008/1
diff --git a/util/arm_boot_tools/mksunxiboot/mksunxiboot.c b/util/arm_boot_tools/mksunxiboot/mksunxiboot.c index 58765b1..493f476 100644 --- a/util/arm_boot_tools/mksunxiboot/mksunxiboot.c +++ b/util/arm_boot_tools/mksunxiboot/mksunxiboot.c @@ -156,7 +156,7 @@ return EXIT_FAILURE; }
- printf("File size: 0x%x\n", file_size); + printf("File size: 0x%lx\n", file_size); if (fread(file_data, file_size, 1, fd_in) != 1) { fprintf(stderr, "Cannot read %s: %s\n", argv[1], strerror(errno)); @@ -168,7 +168,7 @@ if (load_size > SRAM_LOAD_MAX_SIZE) load_size = SRAM_LOAD_MAX_SIZE;
- printf("Load size: 0x%x\n", load_size); + printf("Load size: 0x%lx\n", load_size);
fd_out = fopen(argv[2], "w"); if (!fd_out) {
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32008 )
Change subject: util/arm_boot_tools/mksunxiboot: Correct format string for longs ......................................................................
Patch Set 1: Code-Review+1
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32008
to look at the new patch set (#4).
Change subject: util/arm_boot_tools/mksunxiboot: Correct format strings ......................................................................
util/arm_boot_tools/mksunxiboot: Correct format strings
%lx is the right format string for printing longs.
Found-by: Coverity Scan, CID 1229686, 1229687 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: Ib7ab54dc039bdd60969c79f3c881d69fc68f0d2a --- M util/arm_boot_tools/mksunxiboot/mksunxiboot.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/32008/4
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32008 )
Change subject: util/arm_boot_tools/mksunxiboot: Correct format strings ......................................................................
Patch Set 4: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32008 )
Change subject: util/arm_boot_tools/mksunxiboot: Correct format strings ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32008 )
Change subject: util/arm_boot_tools/mksunxiboot: Correct format strings ......................................................................
util/arm_boot_tools/mksunxiboot: Correct format strings
%lx is the right format string for printing longs.
Found-by: Coverity Scan, CID 1229686, 1229687 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: Ib7ab54dc039bdd60969c79f3c881d69fc68f0d2a Reviewed-on: https://review.coreboot.org/c/coreboot/+/32008 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/arm_boot_tools/mksunxiboot/mksunxiboot.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/util/arm_boot_tools/mksunxiboot/mksunxiboot.c b/util/arm_boot_tools/mksunxiboot/mksunxiboot.c index 58765b1..493f476 100644 --- a/util/arm_boot_tools/mksunxiboot/mksunxiboot.c +++ b/util/arm_boot_tools/mksunxiboot/mksunxiboot.c @@ -156,7 +156,7 @@ return EXIT_FAILURE; }
- printf("File size: 0x%x\n", file_size); + printf("File size: 0x%lx\n", file_size); if (fread(file_data, file_size, 1, fd_in) != 1) { fprintf(stderr, "Cannot read %s: %s\n", argv[1], strerror(errno)); @@ -168,7 +168,7 @@ if (load_size > SRAM_LOAD_MAX_SIZE) load_size = SRAM_LOAD_MAX_SIZE;
- printf("Load size: 0x%x\n", load_size); + printf("Load size: 0x%lx\n", load_size);
fd_out = fopen(argv[2], "w"); if (!fd_out) {
-
Jacob Garber (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)