EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32134
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
mb/google/hatch: Enable Goodix Touch Screen
Enable Goodix touch screen
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch panel
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ib204e6b77b87ba6c775cf38e572476dd9eb37d1d --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/32134/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 984852f..25db624 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -238,6 +238,18 @@ register "stop_off_delay_ms" = "5" device i2c 49 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "100" + register "generic.reset_off_delay_ms" = "5" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end + end end # I2C #1 device pci 15.2 on chip drivers/generic/gpio_keys
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32134
to look at the new patch set (#2).
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
mb/google/hatch: Enable Goodix Touch Screen
Enable Goodix touch screen
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch panel
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ib204e6b77b87ba6c775cf38e572476dd9eb37d1d Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/32134/2
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32134
to look at the new patch set (#3).
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
mb/google/hatch: Enable Goodix Touch Screen
Enable Goodix touch screen
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch panel
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ib204e6b77b87ba6c775cf38e572476dd9eb37d1d Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/32134/3
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32134
to look at the new patch set (#4).
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
mb/google/hatch: Enable Goodix Touch Screen
Enable Goodix touch screen
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch panel
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ib204e6b77b87ba6c775cf38e572476dd9eb37d1d Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/32134/4
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32134
to look at the new patch set (#5).
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
mb/google/hatch: Enable Goodix Touch Screen
Enable Goodix touch screen
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch panel
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ib204e6b77b87ba6c775cf38e572476dd9eb37d1d Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/32134/5
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32134
to look at the new patch set (#6).
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
mb/google/hatch: Enable Goodix Touch Screen
Enable Goodix touch screen.
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch panel
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ib204e6b77b87ba6c775cf38e572476dd9eb37d1d Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/32134/6
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... PS6, Line 248: 100 Where is this 100ms delay from? I don't see it in the datasheet.
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... PS6, Line 249: 5 same with this?
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... PS6, Line 252: 5d so, I2C_ADDR_SEL is pulled low?
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 6:
(3 comments)
I will upload datasheet to my tracker.
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... PS6, Line 248: 100
Where is this 100ms delay from? I don't see it in the datasheet.
datasheet is > 10ms
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... PS6, Line 249: 5
same with this?
datasheet is > 1ms
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... PS6, Line 252: 5d
so, I2C_ADDR_SEL is pulled low?
yes by hw design
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... PS6, Line 248: 100
datasheet is > 10ms
Then, why choose 100? This will affect the boot time as well as resume time.
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... PS6, Line 249: 5
datasheet is > 1ms
Then why choose 5?
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 6:
Patch Set 6:
(2 comments)
Just a brief timing make that work. We can fine tune after this build. Do you have concern about this?
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... PS6, Line 248: 100
Then, why choose 100? This will affect the boot time as well as resume time.
Choose a safe timing for bring up.
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... PS6, Line 249: 5
Then why choose 5?
same reason above.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 6:
(2 comments)
Just a brief timing make that work. We can fine tune after this build. Do you have concern about this?
If that is the case, can you please raise a bug to fine tune these?
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 6:
Patch Set 6:
(2 comments)
Just a brief timing make that work. We can fine tune after this build. Do you have concern about this?
If that is the case, can you please raise a bug to fine tune these?
Sure do. I am testing a half timing now.
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32134
to look at the new patch set (#7).
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
mb/google/hatch: Enable Goodix Touch Screen
Enable Goodix touch screen.
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch panel
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ib204e6b77b87ba6c775cf38e572476dd9eb37d1d Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/32134/7
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/32134/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/32134/7/src/mainboard/google/hatch/variants/... PS7, Line 248: 30 Is this the lowest value that works? Does it fail with 10ms? or 11ms?
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 7:
Patch Set 6:
Patch Set 6:
Patch Set 6:
(2 comments)
Just a brief timing make that work. We can fine tune after this build. Do you have concern about this?
If that is the case, can you please raise a bug to fine tune these?
https://partnerissuetracker.corp.google.com/issues/129727745 Done.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 7:
Patch Set 7:
(1 comment)
I want keep some safe room for bring up. I raise a bug for fine tune.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 7:
Patch Set 7:
(1 comment)
I need sometime for verify minimum value with some stress test. I can't make sure that is work right now.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 7: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 7:
Please mention the datasheet name and version in the commit message.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/32134/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32134/7//COMMIT_MSG@13 PS7, Line 13: panel You write *screen* in the summary.
https://review.coreboot.org/#/c/32134/7//COMMIT_MSG@15 PS7, Line 15: Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Please remove this duplicate line.
Furquan Shaikh has uploaded a new patch set (#8) to the change originally created by EricR Lai. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
mb/google/hatch: Enable Goodix Touch Screen
Enable Goodix touch screen.
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch screen
Change-Id: Ib204e6b77b87ba6c775cf38e572476dd9eb37d1d Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/32134/8
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/32134/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32134/7//COMMIT_MSG@13 PS7, Line 13: panel
You write *screen* in the summary.
Done
https://review.coreboot.org/#/c/32134/7//COMMIT_MSG@15 PS7, Line 15: Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com
Please remove this duplicate line.
Done
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32134
to look at the new patch set (#9).
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
mb/google/hatch: Enable Goodix Touch Screen
Enable Goodix touch screen. Follow GT7375P_Datasheet_Rev.0.1
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch panel
Change-Id: Ib204e6b77b87ba6c775cf38e572476dd9eb37d1d Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/32134/9
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 9: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32134/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32134/9//COMMIT_MSG@14 PS9, Line 14: panel Should this be screen as Furquan updated it to?
Furquan Shaikh has uploaded a new patch set (#10) to the change originally created by EricR Lai. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
mb/google/hatch: Enable Goodix Touch Screen
Enable Goodix touch screen. Follow GT7375P_Datasheet_Rev.0.1
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch screen
Change-Id: Ib204e6b77b87ba6c775cf38e572476dd9eb37d1d Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/32134/10
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/32134/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32134/9//COMMIT_MSG@14 PS9, Line 14: panel
Should this be screen as Furquan updated it to?
Done
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 10: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
mb/google/hatch: Enable Goodix Touch Screen
Enable Goodix touch screen. Follow GT7375P_Datasheet_Rev.0.1
BUG=b:124460799 BRANCH=None TEST=local build and tested with Goodix touch screen
Change-Id: Ib204e6b77b87ba6c775cf38e572476dd9eb37d1d Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32134 Reviewed-by: Shelley Chen shchen@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved Shelley Chen: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 984852f..007f297 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -238,6 +238,19 @@ register "stop_off_delay_ms" = "5" device i2c 49 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "30" + register "generic.reset_off_delay_ms" = "3" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 5d on end + end end # I2C #1 device pci 15.2 on chip drivers/generic/gpio_keys
-
EricR Lai (Code Review) -
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Shelley Chen (Code Review)