[L] Change in coreboot[master]: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI
Attention is currently required from: Christian Walter, Lean Sheng Tan, David.Milosevic@9elements.com.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )
Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ......................................................................
Patch Set 2:
(44 comments)
File src/mainboard/prodrive/atlas/emi.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/1301fcca_1a08f0e3 PS2, Line 75: const EMI_ACCESS access, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/f819c713_4a54239a PS2, Line 75: const EMI_ACCESS access, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/dd23df36_7bb8ac06 PS2, Line 76: const u16 addr, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/52120e97_7231e651 PS2, Line 76: const u16 addr, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/554ce961_a5bc0885 PS2, Line 77: u8 *buff); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/47b265db_c65c00d9 PS2, Line 77: u8 *buff); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/1a9e8d1e_371c9c99 PS2, Line 89: const EMI_ACCESS access, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/8aaa9801_7433cf0c PS2, Line 89: const EMI_ACCESS access, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/8c1317f0_339db71e PS2, Line 90: const u16 addr, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/d06bc0e8_541d4a87 PS2, Line 90: const u16 addr, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/99de8802_5f82d2dc PS2, Line 91: u8 *bytes); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/c107cc6d_45fac682 PS2, Line 91: u8 *bytes); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/eb07dc64_3666efb5 PS2, Line 102: const u16 addr, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/592a3e93_23dd2fca PS2, Line 102: const u16 addr, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/153ad8b5_fe831341 PS2, Line 103: const u16 n, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/fd2ce52f_51326931 PS2, Line 103: const u16 n, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/5cacd0d4_8c932e29 PS2, Line 104: u8 *buff); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/d55f6fc7_77265139 PS2, Line 104: u8 *buff); please, no spaces at the start of a line
File src/mainboard/prodrive/atlas/emi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/0489033a_e55ef781 PS2, Line 42: const EMI_ACCESS access, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/d788f4ea_b3b591f6 PS2, Line 42: const EMI_ACCESS access, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/f625b213_3c003ebb PS2, Line 43: const u16 addr, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/f62fba75_7f04704e PS2, Line 43: const u16 addr, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/7b09b88a_a6d21993 PS2, Line 44: u8 *buff) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/fea303c3_f7207b79 PS2, Line 44: u8 *buff) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/14c0702c_382e7144 PS2, Line 51: switch (access) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/5f78492e_5cd1d21c PS2, Line 80: const EMI_ACCESS access, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/9c3093b6_4da31e07 PS2, Line 80: const EMI_ACCESS access, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/29e2fdd0_a377c55c PS2, Line 81: const u16 addr, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/55f73071_e62d2b86 PS2, Line 81: const u16 addr, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/c8165fff_768505b4 PS2, Line 82: u8 *bytes) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/ec5e31dc_f09a8f36 PS2, Line 82: u8 *bytes) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/7a316a4c_b91a436d PS2, Line 89: switch(access) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/c6acd78d_3f54f85f PS2, Line 89: switch(access) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/d19f5fb0_5bbbeeb6 PS2, Line 118: const u16 addr, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/53a4fc3b_7b9f7937 PS2, Line 118: const u16 addr, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/06f156c2_2c3c2b16 PS2, Line 119: const u16 n, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/9c71008a_5b632110 PS2, Line 119: const u16 n, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/1aefb117_3f40daf7 PS2, Line 120: u8 *buff) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/d9e1075f_fd34b0b0 PS2, Line 120: u8 *buff) please, no spaces at the start of a line
File src/mainboard/prodrive/atlas/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/c7c01c36_bf999157 PS2, Line 14: static const char* get_smbios_part_number(void); "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/04e3cedf_fcb66dff PS2, Line 41: static const char* get_smbios_part_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/smbios.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/5cfff868_1a1a98ab PS2, Line 8: const char* smbios_mainboard_serial_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/vpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/493f724b_b8227b67 PS2, Line 34: switch(vpd) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840): https://review.coreboot.org/c/coreboot/+/68137/comment/2ebb6233_fdb967e8 PS2, Line 34: switch(vpd) { space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)