Attention is currently required from: Christian Walter, Lean Sheng Tan, David.Milosevic@9elements.com.

View Change

44 comments:

• File src/mainboard/prodrive/atlas/emi.h:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 75: const EMI_ACCESS access,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 75: const EMI_ACCESS access,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 76: const u16 addr,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 76: const u16 addr,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 77: u8 *buff);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 77: u8 *buff);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 89: const EMI_ACCESS access,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 89: const EMI_ACCESS access,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 90: const u16 addr,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 90: const u16 addr,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 91: u8 *bytes);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 91: u8 *bytes);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 102: const u16 addr,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 102: const u16 addr,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 103: const u16 n,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 103: const u16 n,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 104: u8 *buff);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 104: u8 *buff);

    please, no spaces at the start of a line

• File src/mainboard/prodrive/atlas/emi.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 42: const EMI_ACCESS access,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 42: const EMI_ACCESS access,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 43: const u16 addr,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 43: const u16 addr,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 44: u8 *buff)

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 44: u8 *buff)

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 51: switch (access) {

    switch and case should be at the same indent

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 80: const EMI_ACCESS access,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 80: const EMI_ACCESS access,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 81: const u16 addr,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 81: const u16 addr,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 82: u8 *bytes)

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 82: u8 *bytes)

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 89: switch(access) {

    switch and case should be at the same indent

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 89: switch(access) {

    space required before the open parenthesis '('

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 118: const u16 addr,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 118: const u16 addr,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 119: const u16 n,

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 119: const u16 n,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 120: u8 *buff)

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 120: u8 *buff)

    please, no spaces at the start of a line

• File src/mainboard/prodrive/atlas/mainboard.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 14: static const char* get_smbios_part_number(void);

    "foo* bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 41: static const char* get_smbios_part_number(void)

    "foo* bar" should be "foo *bar"

• File src/mainboard/prodrive/atlas/smbios.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 8: const char* smbios_mainboard_serial_number(void)

    "foo* bar" should be "foo *bar"

• File src/mainboard/prodrive/atlas/vpd.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 34: switch(vpd) {

    switch and case should be at the same indent

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159840):

    Patch Set #2, Line 34: switch(vpd) {

    space required before the open parenthesis '('

To view, visit change 68137. To unsubscribe, or for help writing mail filters, visit settings.