Change in coreboot[master]: mb/prodrive/hermes: Clean header files

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46564 )

Change subject: mb/prodrive/hermes: Clean header files
......................................................................

mb/prodrive/hermes: Clean header files

Change-Id: I79655a262d92a2e870d131ba7907bd0e94b98071
Signed-off-by: Patrick Rudolph 
---
M src/mainboard/prodrive/hermes/eeprom.c
M src/mainboard/prodrive/hermes/mainboard.c
M src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h
3 files changed, 7 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/46564/1

diff --git a/src/mainboard/prodrive/hermes/eeprom.c b/src/mainboard/prodrive/hermes/eeprom.c
index 763f8bd..5aee54a 100644
--- a/src/mainboard/prodrive/hermes/eeprom.c
+++ b/src/mainboard/prodrive/hermes/eeprom.c
@@ -4,6 +4,9 @@
 #include <console/console.h>
 #include <device/smbus_host.h>
 #include <crc_byte.h>
+#include <soc/intel/common/block/smbus/smbuslib.h>
+#include <soc/pci_devs.h>
+#include <string.h>
 #include "variants/baseboard/include/eeprom.h"

/*
@@ -63,7 +66,7 @@
 #endif

u32 smb_ctrl_reg = pci_read_config32(dev, HOSTC);
-	pci_write_config32(dev, HOSTC, smb_ctrl_reg | HOSTC_I2C_EN);
+	pci_write_config32(dev, HOSTC, smb_ctrl_reg | I2C_EN);

printk(BIOS_SPEW, "%s\tOffset: %04zx\tSize: %02zx\n", __func__,
    	read_offset, size);
diff --git a/src/mainboard/prodrive/hermes/mainboard.c b/src/mainboard/prodrive/hermes/mainboard.c
index d9d89a1..9c263ee 100644
--- a/src/mainboard/prodrive/hermes/mainboard.c
+++ b/src/mainboard/prodrive/hermes/mainboard.c
@@ -2,6 +2,7 @@

#include <acpi/acpigen.h>
 #include <device/device.h>
+#include <soc/soc_chip.h>
 #include "variants/baseboard/include/eeprom.h"
 #include "gpio.h"

diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h b/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h
index 17d55a4..787830e 100644
--- a/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h
+++ b/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h
@@ -1,10 +1,8 @@
 /* SPDX-License-Identifier: GPL-2.0-or-later */

-#include <soc/ramstage.h>
+#include <fsp/api.h>
+#include <fsp/util.h>

-#define HOSTC 0x40
-#define SMBUS_IO_BASE	0xefa0
-#define HOSTC_I2C_EN (1 << 2)
 #define I2C_ADDR_EEPROM 0x57

struct eeprom_board_settings {

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46564 )

Change subject: mb/prodrive/hermes: Clean header files
......................................................................

Patch Set 1: Code-Review+1

Needs a rebase?

[Patrick Rudolph (Code Review)]

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46564

to look at the new patch set (#3).

Change subject: mb/prodrive/hermes: Clean header files
......................................................................

mb/prodrive/hermes: Clean header files

Change-Id: I79655a262d92a2e870d131ba7907bd0e94b98071
Signed-off-by: Patrick Rudolph 
---
M src/mainboard/prodrive/hermes/eeprom.c
M src/mainboard/prodrive/hermes/mainboard.c
M src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h
3 files changed, 6 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/46564/3

[Frans Hendriks (Code Review)]

Attention is currently required from: Patrick Rudolph.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46564 )

Change subject: mb/prodrive/hermes: Clean header files
......................................................................

Patch Set 4:

(1 comment)

File src/mainboard/prodrive/hermes/eeprom.c:

https://review.coreboot.org/c/coreboot/+/46564/comment/5b34813b_9189e6a9 
PS4, Line 63: 	pci_write_config32(PCH_DEV_SMBUS, HOSTC, smb_ctrl_reg | I2C_EN);
Add this change (and removal of defines in .h file to comment.

[Angel Pons (Code Review)]

Attention is currently required from: Frans Hendriks, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46564 )

Change subject: mb/prodrive/hermes: Clean header files
......................................................................

Patch Set 4:

(1 comment)

File src/mainboard/prodrive/hermes/eeprom.c:

https://review.coreboot.org/c/coreboot/+/46564/comment/10bfb966_d92e6f41 
PS4, Line 63: 	pci_write_config32(PCH_DEV_SMBUS, HOSTC, smb_ctrl_reg | I2C_EN);
> Add this change (and removal of defines in .h file to comment.

This change has been superseded by CB:48805 and is no longer necessary. It can be abandoned.

[S] Change in coreboot[master]: mb/prodrive/hermes: Clean header files

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46564?usp=email )

Change subject: mb/prodrive/hermes: Clean header files
......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.