Patrick Rudolph has uploaded this change for review.

View Change

mb/prodrive/hermes: Clean header files

Change-Id: I79655a262d92a2e870d131ba7907bd0e94b98071
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
---
M src/mainboard/prodrive/hermes/eeprom.c
M src/mainboard/prodrive/hermes/mainboard.c
M src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h
3 files changed, 7 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/46564/1
diff --git a/src/mainboard/prodrive/hermes/eeprom.c b/src/mainboard/prodrive/hermes/eeprom.c
index 763f8bd..5aee54a 100644
--- a/src/mainboard/prodrive/hermes/eeprom.c
+++ b/src/mainboard/prodrive/hermes/eeprom.c
@@ -4,6 +4,9 @@
#include <console/console.h>
#include <device/smbus_host.h>
#include <crc_byte.h>
+#include <soc/intel/common/block/smbus/smbuslib.h>
+#include <soc/pci_devs.h>
+#include <string.h>
#include "variants/baseboard/include/eeprom.h"

/*
@@ -63,7 +66,7 @@
#endif

u32 smb_ctrl_reg = pci_read_config32(dev, HOSTC);
- pci_write_config32(dev, HOSTC, smb_ctrl_reg | HOSTC_I2C_EN);
+ pci_write_config32(dev, HOSTC, smb_ctrl_reg | I2C_EN);

printk(BIOS_SPEW, "%s\tOffset: %04zx\tSize: %02zx\n", __func__,
read_offset, size);
diff --git a/src/mainboard/prodrive/hermes/mainboard.c b/src/mainboard/prodrive/hermes/mainboard.c
index d9d89a1..9c263ee 100644
--- a/src/mainboard/prodrive/hermes/mainboard.c
+++ b/src/mainboard/prodrive/hermes/mainboard.c
@@ -2,6 +2,7 @@

#include <acpi/acpigen.h>
#include <device/device.h>
+#include <soc/soc_chip.h>
#include "variants/baseboard/include/eeprom.h"
#include "gpio.h"

diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h b/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h
index 17d55a4..787830e 100644
--- a/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h
+++ b/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h
@@ -1,10 +1,8 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */

-#include <soc/ramstage.h>
+#include <fsp/api.h>
+#include <fsp/util.h>

-#define HOSTC 0x40
-#define SMBUS_IO_BASE 0xefa0
-#define HOSTC_I2C_EN (1 << 2)
#define I2C_ADDR_EEPROM 0x57

struct eeprom_board_settings {

To view, visit change 46564. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79655a262d92a2e870d131ba7907bd0e94b98071
Gerrit-Change-Number: 46564
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-MessageType: newchange