Change in ...coreboot[master]: northbridge/gm45: document that raminit doesn't support mirrored ranks
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33294
Change subject: northbridge/gm45: document that raminit doesn't support mirrored ranks ......................................................................
northbridge/gm45: document that raminit doesn't support mirrored ranks
Change-Id: I8a66a1355974f6771c5e4bae0dc60da2447122d1 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/northbridge/intel/gm45/raminit.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/33294/1
diff --git a/src/northbridge/intel/gm45/raminit.c b/src/northbridge/intel/gm45/raminit.c index 2826d74..b7ccdec 100644 --- a/src/northbridge/intel/gm45/raminit.c +++ b/src/northbridge/intel/gm45/raminit.c @@ -1593,7 +1593,8 @@ int ch, r; FOR_EACH_POPULATED_RANK(dimms, ch, r) { /* We won't do this in dual-interleaved mode, - so don't care about the offset. */ + so don't care about the offset. + Mirrored ranks aren't taken into account here. */ const u32 rankaddr = raminit_get_rank_addr(ch, r); printk(BIOS_DEBUG, "JEDEC init @0x%08x\n", rankaddr); MCHBAR32(DCC_MCHBAR) = (MCHBAR32(DCC_MCHBAR) & ~DCC_SET_EREG_MASK) | DCC_SET_EREGx(2);
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33294 )
Change subject: northbridge/gm45: document that raminit doesn't support mirrored ranks ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33294/1/src/northbridge/intel/gm45/raminit.c File src/northbridge/intel/gm45/raminit.c:
https://review.coreboot.org/#/c/33294/1/src/northbridge/intel/gm45/raminit.c... PS1, Line 1597: Mirrored ranks aren't taken into account here. Don't you just need to switch some bits for that? void send_jedec_cmd() in northbridge/intel/x4x/raminit_ddr23.c does that.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33294 )
Change subject: northbridge/gm45: document that raminit doesn't support mirrored ranks ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33294/1/src/northbridge/intel/gm45/raminit.c File src/northbridge/intel/gm45/raminit.c:
https://review.coreboot.org/#/c/33294/1/src/northbridge/intel/gm45/raminit.c... PS1, Line 1597: Mirrored ranks aren't taken into account here.
Don't you just need to switch some bits for that? void send_jedec_cmd() in northbridge/intel/x4x/ram […]
yep, it's just a bit permutation for the case that the corresponding rank is mirrored
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33294 )
Change subject: northbridge/gm45: document that raminit doesn't support mirrored ranks ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33294 )
Change subject: northbridge/gm45: document that raminit doesn't support mirrored ranks ......................................................................
northbridge/gm45: document that raminit doesn't support mirrored ranks
Change-Id: I8a66a1355974f6771c5e4bae0dc60da2447122d1 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/33294 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/gm45/raminit.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/northbridge/intel/gm45/raminit.c b/src/northbridge/intel/gm45/raminit.c index 2826d74..b7ccdec 100644 --- a/src/northbridge/intel/gm45/raminit.c +++ b/src/northbridge/intel/gm45/raminit.c @@ -1593,7 +1593,8 @@ int ch, r; FOR_EACH_POPULATED_RANK(dimms, ch, r) { /* We won't do this in dual-interleaved mode, - so don't care about the offset. */ + so don't care about the offset. + Mirrored ranks aren't taken into account here. */ const u32 rankaddr = raminit_get_rank_addr(ch, r); printk(BIOS_DEBUG, "JEDEC init @0x%08x\n", rankaddr); MCHBAR32(DCC_MCHBAR) = (MCHBAR32(DCC_MCHBAR) & ~DCC_SET_EREG_MASK) | DCC_SET_EREGx(2);
-
Arthur Heymans (Code Review) -
Felix Held (Code Review)