Felix Held has uploaded this change for review.

View Change

northbridge/gm45: document that raminit doesn't support mirrored ranks

Change-Id: I8a66a1355974f6771c5e4bae0dc60da2447122d1
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
---
M src/northbridge/intel/gm45/raminit.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/33294/1

diff --git a/src/northbridge/intel/gm45/raminit.c b/src/northbridge/intel/gm45/raminit.c
index 2826d74..b7ccdec 100644
--- a/src/northbridge/intel/gm45/raminit.c
+++ b/src/northbridge/intel/gm45/raminit.c
@@ -1593,7 +1593,8 @@
 	int ch, r;
 	FOR_EACH_POPULATED_RANK(dimms, ch, r) {
 		/* We won't do this in dual-interleaved mode,
-		   so don't care about the offset. */
+		   so don't care about the offset.
+		   Mirrored ranks aren't taken into account here. */
 		const u32 rankaddr = raminit_get_rank_addr(ch, r);
 		printk(BIOS_DEBUG, "JEDEC init @0x%08x\n", rankaddr);
 		MCHBAR32(DCC_MCHBAR) = (MCHBAR32(DCC_MCHBAR) & ~DCC_SET_EREG_MASK) | DCC_SET_EREGx(2);

To view, visit change 33294. To unsubscribe, or for help writing mail filters, visit settings.