Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83066?usp=email )
Change subject: cpu/x86: Move SMI GSMI calls entry to a common place
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Patchset:
PS4:
Nice dedup!
File src/drivers/elog/gsmi.c:
https://review.coreboot.org/c/coreboot/+/83066/comment/e2e869f7_8783283b?usp... :
PS4, Line 148: ¶m
Wouldn't hurt to change the API to make it a simple u32 instead of a pointer.
Just comparing the calling sites, it looked like the semantics are change
(originally passing a pointer into the save state, now passing a pointer to
the stack.) But it doesn't matter as gsmi_exec() only reads it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83066?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I93639d8d0fde2e874eb9b963c449be1b754ca63d
Gerrit-Change-Number: 83066
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 16 Jun 2024 12:43:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes