Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.

Patch set 4:Code-Review +2

View Change

2 comments:

• Patchset:

  • Patch Set #4:

    Nice dedup!

• File src/drivers/elog/gsmi.c:

  • Patch Set #4, Line 148: &param

    Wouldn't hurt to change the API to make it a simple u32 instead of a pointer.
    Just comparing the calling sites, it looked like the semantics are change
    (originally passing a pointer into the save state, now passing a pointer to
    the stack.) But it doesn't matter as gsmi_exec() only reads it.

To view, visit change 83066. To unsubscribe, or for help writing mail filters, visit settings.