Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38156 )
Change subject: drivers/i2c/adm1026: Drop unused hardware monitor support ......................................................................
drivers/i2c/adm1026: Drop unused hardware monitor support
Change-Id: I4e2ebe4f2a90cc27f9a4de907b873df44718234d Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- D src/drivers/i2c/adm1026/Kconfig D src/drivers/i2c/adm1026/Makefile.inc D src/drivers/i2c/adm1026/adm1026.c 3 files changed, 0 insertions(+), 74 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/38156/1
diff --git a/src/drivers/i2c/adm1026/Kconfig b/src/drivers/i2c/adm1026/Kconfig deleted file mode 100644 index 8168b29..0000000 --- a/src/drivers/i2c/adm1026/Kconfig +++ /dev/null @@ -1,2 +0,0 @@ -config DRIVERS_I2C_ADM1026 - bool diff --git a/src/drivers/i2c/adm1026/Makefile.inc b/src/drivers/i2c/adm1026/Makefile.inc deleted file mode 100644 index 7652a75..0000000 --- a/src/drivers/i2c/adm1026/Makefile.inc +++ /dev/null @@ -1 +0,0 @@ -ramstage-$(CONFIG_DRIVERS_I2C_ADM1026) += adm1026.c diff --git a/src/drivers/i2c/adm1026/adm1026.c b/src/drivers/i2c/adm1026/adm1026.c deleted file mode 100644 index c1bd905..0000000 --- a/src/drivers/i2c/adm1026/adm1026.c +++ /dev/null @@ -1,71 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <console/console.h> -#include <device/device.h> -#include <device/smbus.h> - -#define ADM1026_DEVICE 0x2d /* Either 0x2c or 0x2d or 0x2e */ -#define ADM1026_REG_CONFIG1 0x00 -#define CFG1_MONITOR 0x01 -#define CFG1_INT_ENABLE 0x02 -#define CFG1_INT_CLEAR 0x04 -#define CFG1_AIN8_9 0x08 -#define CFG1_THERM_HOT 0x10 -#define CFT1_DAC_AFC 0x20 -#define CFG1_PWM_AFC 0x40 -#define CFG1_RESET 0x80 -#define ADM1026_REG_CONFIG2 0x01 -#define ADM1026_REG_CONFIG3 0x07 - -static void adm1026_enable_monitoring(struct device *dev) -{ - int result; - result = smbus_read_byte(dev, ADM1026_REG_CONFIG1); - - result = (result | CFG1_MONITOR) & ~(CFG1_INT_CLEAR | CFG1_RESET); - result = smbus_write_byte(dev, ADM1026_REG_CONFIG1, result); - - result = smbus_read_byte(dev, ADM1026_REG_CONFIG1); - if (!(result & CFG1_MONITOR)) { - printk(BIOS_DEBUG, "ADM1026: monitoring would not enable"); - } -} - -static void adm1026_init(struct device *dev) -{ - if (dev->enabled && dev->path.type == DEVICE_PATH_I2C) { - if (ops_smbus_bus(get_pbus_smbus(dev))) { - if (dev->bus->dev->path.type == DEVICE_PATH_I2C) - smbus_set_link(dev); // it is under mux - adm1026_enable_monitoring(dev); - } - } -} - -static struct device_operations adm1026_operations = { - .read_resources = DEVICE_NOOP, - .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, - .init = adm1026_init, -}; - -static void enable_dev(struct device *dev) -{ - dev->ops = &adm1026_operations; -} - -struct chip_operations drivers_i2c_adm1026_ops = { - CHIP_NAME("adm1026") - .enable_dev = enable_dev, -};
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38156 )
Change subject: drivers/i2c/adm1026: Drop unused hardware monitor support ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38156 )
Change subject: drivers/i2c/adm1026: Drop unused hardware monitor support ......................................................................
drivers/i2c/adm1026: Drop unused hardware monitor support
Change-Id: I4e2ebe4f2a90cc27f9a4de907b873df44718234d Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38156 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- D src/drivers/i2c/adm1026/Kconfig D src/drivers/i2c/adm1026/Makefile.inc D src/drivers/i2c/adm1026/adm1026.c 3 files changed, 0 insertions(+), 74 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/drivers/i2c/adm1026/Kconfig b/src/drivers/i2c/adm1026/Kconfig deleted file mode 100644 index 8168b29..0000000 --- a/src/drivers/i2c/adm1026/Kconfig +++ /dev/null @@ -1,2 +0,0 @@ -config DRIVERS_I2C_ADM1026 - bool diff --git a/src/drivers/i2c/adm1026/Makefile.inc b/src/drivers/i2c/adm1026/Makefile.inc deleted file mode 100644 index 7652a75..0000000 --- a/src/drivers/i2c/adm1026/Makefile.inc +++ /dev/null @@ -1 +0,0 @@ -ramstage-$(CONFIG_DRIVERS_I2C_ADM1026) += adm1026.c diff --git a/src/drivers/i2c/adm1026/adm1026.c b/src/drivers/i2c/adm1026/adm1026.c deleted file mode 100644 index c1bd905..0000000 --- a/src/drivers/i2c/adm1026/adm1026.c +++ /dev/null @@ -1,71 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <console/console.h> -#include <device/device.h> -#include <device/smbus.h> - -#define ADM1026_DEVICE 0x2d /* Either 0x2c or 0x2d or 0x2e */ -#define ADM1026_REG_CONFIG1 0x00 -#define CFG1_MONITOR 0x01 -#define CFG1_INT_ENABLE 0x02 -#define CFG1_INT_CLEAR 0x04 -#define CFG1_AIN8_9 0x08 -#define CFG1_THERM_HOT 0x10 -#define CFT1_DAC_AFC 0x20 -#define CFG1_PWM_AFC 0x40 -#define CFG1_RESET 0x80 -#define ADM1026_REG_CONFIG2 0x01 -#define ADM1026_REG_CONFIG3 0x07 - -static void adm1026_enable_monitoring(struct device *dev) -{ - int result; - result = smbus_read_byte(dev, ADM1026_REG_CONFIG1); - - result = (result | CFG1_MONITOR) & ~(CFG1_INT_CLEAR | CFG1_RESET); - result = smbus_write_byte(dev, ADM1026_REG_CONFIG1, result); - - result = smbus_read_byte(dev, ADM1026_REG_CONFIG1); - if (!(result & CFG1_MONITOR)) { - printk(BIOS_DEBUG, "ADM1026: monitoring would not enable"); - } -} - -static void adm1026_init(struct device *dev) -{ - if (dev->enabled && dev->path.type == DEVICE_PATH_I2C) { - if (ops_smbus_bus(get_pbus_smbus(dev))) { - if (dev->bus->dev->path.type == DEVICE_PATH_I2C) - smbus_set_link(dev); // it is under mux - adm1026_enable_monitoring(dev); - } - } -} - -static struct device_operations adm1026_operations = { - .read_resources = DEVICE_NOOP, - .set_resources = DEVICE_NOOP, - .enable_resources = DEVICE_NOOP, - .init = adm1026_init, -}; - -static void enable_dev(struct device *dev) -{ - dev->ops = &adm1026_operations; -} - -struct chip_operations drivers_i2c_adm1026_ops = { - CHIP_NAME("adm1026") - .enable_dev = enable_dev, -};
-
Kyösti Mälkki (Code Review) -
Nico Huber (Code Review)