Attention is currently required from: Felix Singer, Patrick Rudolph. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52810 )
Change subject: soc/intel/skylake: Use set_dev_state_by_devicetree() ......................................................................
Patch Set 1:
(3 comments)
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/52810/comment/747a057a_fc394058 PS1, Line 461: (!xdci_can_enable()) : params->XdciEnable = 0; params->XdciEnable = xdci_can_enable();
File src/soc/intel/skylake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/52810/comment/39d3d9f2_d4541927 PS1, Line 15: newline?
https://review.coreboot.org/c/coreboot/+/52810/comment/eb1ed61a_e593ee04 PS1, Line 137: PCH_DEVFN_SMBUS }, : { &m_cfg->EnableTraceHub, P alignment