Change in coreboot[master]: [RFC] device: Introduce new method for setting device states

[Michael Niewöhner (Code Review)]

Attention is currently required from:  Felix Singer, Nico Huber, Raul Rangel, Furquan Shaikh, Matt DeVillier, Angel Pons, Patrick Rudolph, Felix Held.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52493 )

Change subject: [RFC] device: Introduce new method for setting device states
......................................................................


Patch Set 14:

(3 comments)

File src/include/device/devenmap.h:

https://review.coreboot.org/c/coreboot/+/52493/comment/e578a174_122781f5 
PS14, Line 12: const
not sure if that's right. Nico?


https://review.coreboot.org/c/coreboot/+/52493/comment/58c3c046_812fa5c6 
PS14, Line 12: uint8_t
probably const


https://review.coreboot.org/c/coreboot/+/52493/comment/eb9a1b2c_9ea51070 
PS14, Line 17: const
drop here; keep in function definition; see comment here https://review.coreboot.org/c/coreboot/+/52493/comment/934c3a3b_2b638efb/



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52493
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70fde306c65a8881f565c5f923be20f380ea64d3
Gerrit-Change-Number: 52493
Gerrit-PatchSet: 14
Gerrit-Owner:  Felix Singer <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Furquan Shaikh <[e-mail]>
Gerrit-Reviewer: Matt DeVillier <[e-mail]>
Gerrit-Reviewer: Michael Niewöhner <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Raul Rangel <[e-mail]>
Gerrit-Reviewer: Tim Wawrzynczak <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention:  Felix Singer <[e-mail]>
Gerrit-Attention: Nico Huber <[e-mail]>
Gerrit-Attention: Raul Rangel <[e-mail]>
Gerrit-Attention: Furquan Shaikh <[e-mail]>
Gerrit-Attention: Matt DeVillier <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Patrick Rudolph <[e-mail]>
Gerrit-Attention: Felix Held <[e-mail]>
Gerrit-Comment-Date: Sat, 01 May 2021 00:28:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment