Change in coreboot[master]: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezki...
Lucas Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil.
Current Ram_Id: 0011 MT40A1G16KNR-075-E never be built before. Remove it and change use micron-MT40A1G16KD-062E-E for ram_id:0011.
BRANCH=zork BUG=b:159316110 TEST=run gen_part_id then check the generated files.
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: I28fc39f17e06ecd39f6567613e6ff5919becb2fd --- M src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc M src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt 3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45810/1
diff --git a/src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc b/src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc index 65eb7b0..12e7fa9 100644 --- a/src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc @@ -3,7 +3,7 @@
SPD_SOURCES = SPD_SOURCES += ddr4-spd-3.hex # ID = 0(0b0000) Parts = H5AN8G6NCJR-VKC -SPD_SOURCES += ddr4-spd-empty.hex # ID = 1(0b0001) +SPD_SOURCES += ddr4-spd-empty.bin # ID = 1(0b0001) SPD_SOURCES += ddr4-spd-1.hex # ID = 2(0b0010) Parts = MT40A512M16TB-062E:J -SPD_SOURCES += ddr4-spd-4.hex # ID = 3(0b0011) Parts = MT40A1G16KNR-075:E +SPD_SOURCES += ddr4-spd-7.hex # ID = 3(0b0011) Parts = MT40A1G16KD-062E:E SPD_SOURCES += ddr4-spd-3.hex # ID = 4(0b0100) Parts = K4A8G165WC-BCTD diff --git a/src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt index 99072f6..7e54cc1 100644 --- a/src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt +++ b/src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt @@ -1,5 +1,5 @@ DRAM Part Name ID to assign H5AN8G6NCJR-VKC 0 (0000) MT40A512M16TB-062E:J 2 (0010) -MT40A1G16KNR-075:E 3 (0011) +MT40A1G16KD-062E:E 3 (0011) K4A8G165WC-BCTD 4 (0100) diff --git a/src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt index a9994a3..b4b1601 100644 --- a/src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt +++ b/src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt @@ -9,5 +9,5 @@ # Part Name, Fixed ID (optional) H5AN8G6NCJR-VKC,0 MT40A512M16TB-062E:J,2 -MT40A1G16KNR-075:E, 3 +MT40A1G16KD-062E:E,3 K4A8G165WC-BCTD,4
Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 1: Code-Review+1
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 1: Code-Review+1
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Please rebase on https://review.coreboot.org/c/coreboot/+/45818.
https://review.coreboot.org/c/coreboot/+/45810/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45810/1/src/mainboard/google/zork/v... PS1, Line 6: SPD_SOURCES += ddr4-spd-empty.bin # ID = 1(0b0001) Looks like the tool changed. This change needs to be rebased on https://review.coreboot.org/c/coreboot/+/45818.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45810/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45810/1/src/mainboard/google/zork/v... PS1, Line 8: SPD_SOURCES += ddr4-spd-7.hex # ID = 3(0b0011) Parts = MT40A1G16KD-062E:E Are you confident there are no boards using MT40A1G16KNR-075:E?
Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45810/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45810/1/src/mainboard/google/zork/v... PS1, Line 8: SPD_SOURCES += ddr4-spd-7.hex # ID = 3(0b0011) Parts = MT40A1G16KD-062E:E
Are you confident there are no boards using MT40A1G16KNR-075:E?
This memory never be used is only mean on Ezkinil project.(proto/EVT). We don't know the others variant.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45810/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45810/1/src/mainboard/google/zork/v... PS1, Line 8: SPD_SOURCES += ddr4-spd-7.hex # ID = 3(0b0011) Parts = MT40A1G16KD-062E:E
This memory never be used is only mean on Ezkinil project.(proto/EVT). […]
Thank you. I should have clarified that my question only applies to Ezkinil.
Hello build bot (Jenkins), David Wu, Patrick Georgi, Martin Roth, Bhanu Prakash Maiya, Vincent Wang, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45810
to look at the new patch set (#2).
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil.
Current Ram_Id: 0011 MT40A1G16KNR-075-E never be built before. Remove it and change use micron-MT40A1G16KD-062E-E for ram_id:0011.
BRANCH=zork BUG=b:159316110 TEST=run gen_part_id then check the generated files.
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: I28fc39f17e06ecd39f6567613e6ff5919becb2fd --- M src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc M src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt 3 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45810/2
Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 2: Code-Review+1
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45810/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45810/1/src/mainboard/google/zork/v... PS1, Line 6: SPD_SOURCES += ddr4-spd-empty.bin # ID = 1(0b0001)
Looks like the tool changed. This change needs to be rebased on https://review.coreboot. […]
Gerrit isn't seeing this as a rebase on https://review.coreboot.org/c/coreboot/+/45818. Your git log should show 1c8d99bdd5a4c690d5db630e41630bd27c6df1ca as the parent commit.
David Wu has uploaded a new patch set (#3) to the change originally created by Lucas Chen. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil.
Current Ram_Id: 0011 MT40A1G16KNR-075-E never be built before. Remove it and change use micron-MT40A1G16KD-062E-E for ram_id:0011.
BRANCH=zork BUG=b:159316110 TEST=run gen_part_id then check the generated files.
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: I28fc39f17e06ecd39f6567613e6ff5919becb2fd --- M src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc M src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45810/3
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 3:
(1 comment)
Please explain in the commit message why the id needs to be fixed to 3. The tool would assign id 1 if the id was not fixed to 3.
https://review.coreboot.org/c/coreboot/+/45810/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45810/1/src/mainboard/google/zork/v... PS1, Line 6: SPD_SOURCES += ddr4-spd-empty.bin # ID = 1(0b0001)
Gerrit isn't seeing this as a rebase on https://review.coreboot.org/c/coreboot/+/45818. […]
Done
Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 3: Code-Review+1
Patch Set 3:
(1 comment)
Please explain in the commit message why the id needs to be fixed to 3. The tool would assign id 1 if the id was not fixed to 3.
Because we had a previous CL in chromium gerrit which had been merged in June. So we just think we can use new memory to replace old one on same ram_id3,The next build we will build some pcs with this new memory. And this sku are ready the ram_id specify to ram_id:3 and the SMT use BOM (bill of matterial)are ready to ram_is is 3. This ram_id doesn't need have to dedicate to 3, It can be changed, but for ezkinil DVT build 10/12, It is late to change BOM ram_id from today. So we think if we can keep no change BOM without problem, It would be better for the BOM ready.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 3: Code-Review+1
Hello build bot (Jenkins), David Wu, Patrick Georgi, Martin Roth, Bhanu Prakash Maiya, Vincent Wang, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45810
to look at the new patch set (#4).
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil.
Current Ram_Id: 0011 MT40A1G16KNR-075-E never be built before. Remove it and change use micron-MT40A1G16KD-062E-E for ram_id:0011.
BRANCH=zork BUG=b:159316110 TEST=run gen_part_id then check the generated files.
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: I28fc39f17e06ecd39f6567613e6ff5919becb2fd --- M src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc M src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt 3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45810/4
Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 4: Code-Review+1
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 4: Code-Review+1
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45810/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45810/4/src/mainboard/google/zork/v... PS4, Line 6: bin I'm not sure this is right. Everything currently checked in still uses the .hex extension.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 4: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/45810/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45810/4/src/mainboard/google/zork/v... PS4, Line 6: bin
I'm not sure this is right. Everything currently checked in still uses the .hex extension.
This was rolled back here. This change needs to be rebased on this revert.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45810/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45810/4/src/mainboard/google/zork/v... PS4, Line 6: bin
This was rolled back here. This change needs to be rebased on this revert.
Forgot to include the patch: CB:44999
Lucas Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45810/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45810/4/src/mainboard/google/zork/v... PS4, Line 6: bin
Forgot to include the patch: CB:44999
Because i think the last revert CL https://review.coreboot.org/44999 already be merged, So i repo sync first, then go build the two tools, Rerun gen_part_iid then update to the CL patch 4. Is it incorrect? Should i use git chectout to rebase to the CL https://review.coreboot.org/44999 ?
Rob Barnes has uploaded a new patch set (#5) to the change originally created by Lucas Chen. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil.
Current Ram_Id: 0011 MT40A1G16KNR-075-E never be built before. Remove it and change use micron-MT40A1G16KD-062E-E for ram_id:0011.
BRANCH=zork BUG=b:159316110 TEST=run gen_part_id then check the generated files.
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: I28fc39f17e06ecd39f6567613e6ff5919becb2fd --- M src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc M src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45810/5
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 5: Code-Review+1
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45810/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45810/4/src/mainboard/google/zork/v... PS4, Line 6: bin
Because i think the last revert CL https://review.coreboot. […]
Rebased on master and reran the tools. Empty is back to hex now.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 5: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
Patch Set 5: Code-Review+2
Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45810 )
Change subject: zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil. ......................................................................
zork/var/ezkinil: Add micron-MT40A1G16KD-062E-E in SPD table for Ezkinil.
Current Ram_Id: 0011 MT40A1G16KNR-075-E never be built before. Remove it and change use micron-MT40A1G16KD-062E-E for ram_id:0011.
BRANCH=zork BUG=b:159316110 TEST=run gen_part_id then check the generated files.
Signed-off-by: Lucas Chen lucas.chen@quanta.corp-partner.google.com Change-Id: I28fc39f17e06ecd39f6567613e6ff5919becb2fd Reviewed-on: https://review.coreboot.org/c/coreboot/+/45810 Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc M src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt 3 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Paul Fagerburg: Looks good to me, approved Rob Barnes: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc b/src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc index 65eb7b0..10dea1c 100644 --- a/src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/ezkinil/spd/Makefile.inc @@ -5,5 +5,5 @@ SPD_SOURCES += ddr4-spd-3.hex # ID = 0(0b0000) Parts = H5AN8G6NCJR-VKC SPD_SOURCES += ddr4-spd-empty.hex # ID = 1(0b0001) SPD_SOURCES += ddr4-spd-1.hex # ID = 2(0b0010) Parts = MT40A512M16TB-062E:J -SPD_SOURCES += ddr4-spd-4.hex # ID = 3(0b0011) Parts = MT40A1G16KNR-075:E +SPD_SOURCES += ddr4-spd-7.hex # ID = 3(0b0011) Parts = MT40A1G16KD-062E:E SPD_SOURCES += ddr4-spd-3.hex # ID = 4(0b0100) Parts = K4A8G165WC-BCTD diff --git a/src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt index 99072f6..7e54cc1 100644 --- a/src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt +++ b/src/mainboard/google/zork/variants/ezkinil/spd/dram_id.generated.txt @@ -1,5 +1,5 @@ DRAM Part Name ID to assign H5AN8G6NCJR-VKC 0 (0000) MT40A512M16TB-062E:J 2 (0010) -MT40A1G16KNR-075:E 3 (0011) +MT40A1G16KD-062E:E 3 (0011) K4A8G165WC-BCTD 4 (0100) diff --git a/src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt index a9994a3..b4b1601 100644 --- a/src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt +++ b/src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt @@ -9,5 +9,5 @@ # Part Name, Fixed ID (optional) H5AN8G6NCJR-VKC,0 MT40A512M16TB-062E:J,2 -MT40A1G16KNR-075:E, 3 +MT40A1G16KD-062E:E,3 K4A8G165WC-BCTD,4
-
David Wu (Code Review) -
Lucas Chen (Code Review)
-
Martin Roth (Code Review)
-
Paul Fagerburg (Code Review)
-
Rob Barnes (Code Review)