Patch Set 3:

(1 comment)

Please explain in the commit message why the id needs to be fixed to 3. The tool would assign id 1 if the id was not fixed to 3.

Because we had a previous CL in chromium gerrit which had been merged in June. So we just think we can use new memory to replace old one on same ram_id3,The next build we will build some pcs with this new memory. And this sku are ready the ram_id specify to ram_id:3 and the SMT use BOM (bill of matterial)are ready to ram_is is 3. This ram_id doesn't need have to dedicate to 3, It can be changed, but for ezkinil DVT build 10/12, It is late to change BOM ram_id from today. So we think if we can keep no change BOM without problem, It would be better for the BOM ready.

Patch set 3:Code-Review +1

View Change

To view, visit change 45810. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28fc39f17e06ecd39f6567613e6ff5919becb2fd
Gerrit-Change-Number: 45810
Gerrit-PatchSet: 3
Gerrit-Owner: Lucas Chen <lucas.chen@quanta.corp-partner.google.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya@google.com>
Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com>
Gerrit-Reviewer: Lucas Chen <lucas.chen@quanta.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes@google.com>
Gerrit-Reviewer: Vincent Wang <vwang@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Teresa Tseng <teresa_tseng@quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 30 Sep 2020 02:09:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment