Please explain in the commit message why the id needs to be fixed to 3. The tool would assign id 1 if the id was not fixed to 3.

View Change

1 comment:

To view, visit change 45810. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28fc39f17e06ecd39f6567613e6ff5919becb2fd
Gerrit-Change-Number: 45810
Gerrit-PatchSet: 3
Gerrit-Owner: Lucas Chen <lucas.chen@quanta.corp-partner.google.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya@google.com>
Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com>
Gerrit-Reviewer: Lucas Chen <lucas.chen@quanta.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes@google.com>
Gerrit-Reviewer: Vincent Wang <vwang@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Teresa Tseng <teresa_tseng@quanta.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 29 Sep 2020 16:18:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes <robbarnes@google.com>
Gerrit-MessageType: comment